Issue 345443003: v8 atomicops: Drop SSE2 detection if __SSE2__ is defined.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 345443003: v8 atomicops: Drop SSE2 detection if SSE2 is defined. (Closed)

Created:
6 years, 6 months ago by Nico

Modified:
6 years, 5 months ago

Reviewers:
jochen (gone - plz use gerrit), Jakob Kummerow

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

More Reviews

Description

v8 atomicops: Drop SSE2 detection if __SSE2__ is defined. Chromium always builds with -msse2 these days. Apparently v8's x87 backend doesn't have SSE2, so make this dependend on a preprocessor define. This is similar to Chromium's https://codereview.chromium.org/291993003/ BUG=chromium:348761, chromium:94925 LOG=N

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -2 lines)			Patch
M	src/base/atomicops_internals_tsan.h	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/base/atomicops_internals_x86_gcc.h	View	1 2	2 chunks	+3 lines, -1 line	0 comments	Download
M	src/base/atomicops_internals_x86_gcc.cc	View	1 2 3	1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Jakob Kummerow

6 years, 6 months ago (2014-06-23 08:28:59 UTC) #6

Wait a second. In the _tsan header, that struct isn't used at all, so it can
just be dropped entirely (see [1]). In the _x86_gcc header, the #ifdef is fine,
but we'll have to manually revert the corresponding half of [1] first.

[1] https://codereview.chromium.org/342323002