src/base/atomicops_internals_x86_gcc.h - Issue 345443003: v8 atomicops: Drop SSE2 detection if __SSE2__ is defined.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/base/atomicops_internals_x86_gcc.h

Issue 345443003: v8 atomicops: Drop SSE2 detection if __SSE2__ is defined. (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/base/atomicops_internals_x86_gcc.h

===================================================================

--- src/base/atomicops_internals_x86_gcc.h (revision 21880)

+++ src/base/atomicops_internals_x86_gcc.h (working copy)

@@ -17,7 +17,9 @@

struct AtomicOps_x86CPUFeatureStruct {

bool has_amd_lock_mb_bug; // Processor has AMD memory-barrier bug; do lfence

// after acquire compare-and-swap.

+#if !defined(__SSE2__)

bool has_sse2; // Processor has SSE2.

+#endif

};

extern struct AtomicOps_x86CPUFeatureStruct AtomicOps_Internalx86CPUFeatures;

@@ -92,7 +94,7 @@

*ptr = value;

}

-#if defined(__x86_64__)

+#if defined(__x86_64__) || defined(__SSE2__)

// 64-bit implementations of memory barrier can be simpler, because it

// "mfence" is guaranteed to exist.

« no previous file with comments | « src/base/atomicops_internals_tsan.h ('k') | src/base/atomicops_internals_x86_gcc.cc » ('j') | no next file with comments »