Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Issue 342323002: Clean up unused stuff in atomicops_internals_{tsan,gcc}.h (Closed)

Created:
6 years, 6 months ago by Jakob Kummerow
Modified:
6 years, 6 months ago
CC:
v8-dev
Visibility:
Public.

Description

Clean up unused stuff in atomicops_internals_{tsan,x86_gcc}.h This ports crrev.com/278081 and crrev.com/271506 to V8. R=glider@chromium.org, svenpanne@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=21901

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -47 lines) Patch
M src/base/atomicops_internals_tsan.h View 2 chunks +0 lines, -16 lines 0 comments Download
M src/base/atomicops_internals_x86_gcc.h View 3 chunks +1 line, -27 lines 0 comments Download
M src/base/atomicops_internals_x86_gcc.cc View 2 chunks +0 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Jakob Kummerow
This is per https://codereview.chromium.org/339343002/#msg7. While I was at it, I cleaned up the gcc version ...
6 years, 6 months ago (2014-06-20 12:22:23 UTC) #1
Alexander Potapenko
LGTM, thanks!
6 years, 6 months ago (2014-06-20 12:25:21 UTC) #2
Sven Panne
LGTM, too, but can we please add the relevant Chromium commit numbers to this CL? ...
6 years, 6 months ago (2014-06-20 12:29:00 UTC) #3
Jakob Kummerow
6 years, 6 months ago (2014-06-20 12:59:02 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r21901 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698