Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 344443007: Encapsulate implementation-specific timeline record handling in TimelineUIUtils (Closed)

Created:
6 years, 6 months ago by yurys
Modified:
6 years, 6 months ago
Reviewers:
caseq, pfeldman, loislo
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

Encapsulate implementation-specific timeline record handling in TimelineUIUtils TimelineUIUtils now has two descendants: - TracingTimelineUIUtils for tracing based timeline records - TimelineUIUtilsImpl for timeline records based on Timeline agent events This patch moves some of UI-specific getters from TimelineModel.Record into TimelineUIUtils instance methods. In the end we should have all ui logic that depends on particular backend details to be encapsulated in TimelineUIUtils instance. BUG=361045 R=caseq@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176405

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+222 lines, -113 lines) Patch
M Source/devtools/devtools.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M Source/devtools/front_end/timeline/MemoryCountersGraph.js View 2 chunks +4 lines, -2 lines 0 comments Download
M Source/devtools/front_end/timeline/TimelineEventOverview.js View 2 chunks +4 lines, -3 lines 0 comments Download
M Source/devtools/front_end/timeline/TimelineMemoryOverview.js View 3 chunks +6 lines, -3 lines 0 comments Download
M Source/devtools/front_end/timeline/TimelineModel.js View 1 chunk +0 lines, -15 lines 0 comments Download
M Source/devtools/front_end/timeline/TimelineModelImpl.js View 1 chunk +0 lines, -36 lines 0 comments Download
M Source/devtools/front_end/timeline/TimelinePanel.js View 5 chunks +8 lines, -7 lines 0 comments Download
M Source/devtools/front_end/timeline/TimelinePresentationModel.js View 3 chunks +5 lines, -5 lines 0 comments Download
M Source/devtools/front_end/timeline/TimelineUIUtils.js View 2 chunks +44 lines, -7 lines 0 comments Download
A Source/devtools/front_end/timeline/TimelineUIUtilsImpl.js View 1 chunk +75 lines, -0 lines 0 comments Download
M Source/devtools/front_end/timeline/TimelineView.js View 2 chunks +5 lines, -4 lines 0 comments Download
M Source/devtools/front_end/timeline/TracingTimelineModel.js View 2 chunks +8 lines, -24 lines 0 comments Download
M Source/devtools/front_end/timeline/TracingTimelineUIUtils.js View 2 chunks +61 lines, -7 lines 0 comments Download
M Source/devtools/scripts/frontend_modules.json View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
yurys
6 years, 6 months ago (2014-06-18 09:21:51 UTC) #1
caseq
lgtm
6 years, 6 months ago (2014-06-18 09:25:30 UTC) #2
yurys
6 years, 6 months ago (2014-06-18 09:38:29 UTC) #3
Message was sent while issue was closed. 
Committed patchset #1 manually as r176405 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698