Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Unified Diff: Source/devtools/front_end/timeline/TimelinePresentationModel.js

Issue 344443007: Encapsulate implementation-specific timeline record handling in TimelineUIUtils (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/devtools/front_end/timeline/TimelinePresentationModel.js
diff --git a/Source/devtools/front_end/timeline/TimelinePresentationModel.js b/Source/devtools/front_end/timeline/TimelinePresentationModel.js
index 476d16014265e9c6aebdcdd02a1c5b7c14e97a16..b5b23bcd054805f01b5b45efe559513ba44bec71 100644
--- a/Source/devtools/front_end/timeline/TimelinePresentationModel.js
+++ b/Source/devtools/front_end/timeline/TimelinePresentationModel.js
@@ -33,12 +33,12 @@
* @constructor
* @extends {WebInspector.Object}
* @param {!WebInspector.TimelineModel} model
- * @param {!Object.<string, number>} coalescableRecordTypes
+ * @param {!WebInspector.TimelineUIUtils} uiUtils
*/
-WebInspector.TimelinePresentationModel = function(model, coalescableRecordTypes)
+WebInspector.TimelinePresentationModel = function(model, uiUtils)
{
this._model = model;
- this._coalescableRecordTypes = coalescableRecordTypes;
+ this._uiUtils = uiUtils;
this._filters = [];
/**
* @type {!Map.<!WebInspector.TimelineModel.Record, !WebInspector.TimelinePresentationModel.Record>}
@@ -88,7 +88,7 @@ WebInspector.TimelinePresentationModel.prototype = {
*/
addRecord: function(record)
{
- if (record.isProgram()) {
+ if (this._uiUtils.isProgram(record)) {
var records = record.children();
for (var i = 0; i < records.length; ++i)
this._innerAddRecord(this._rootRecord, records[i]);
@@ -145,7 +145,7 @@ WebInspector.TimelinePresentationModel.prototype = {
return null;
if (lastRecord.record().type() !== record.type())
return null;
- if (!this._coalescableRecordTypes[record.type()])
+ if (!this._uiUtils.isCoalescable(record.type()))
return null;
if (lastRecord.record().endTime() + coalescingThresholdMillis < startTime)
return null;
« no previous file with comments | « Source/devtools/front_end/timeline/TimelinePanel.js ('k') | Source/devtools/front_end/timeline/TimelineUIUtils.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698