Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6739)

Unified Diff: Source/devtools/front_end/timeline/TimelineUIUtils.js

Issue 344443007: Encapsulate implementation-specific timeline record handling in TimelineUIUtils (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/devtools/front_end/timeline/TimelineUIUtils.js
diff --git a/Source/devtools/front_end/timeline/TimelineUIUtils.js b/Source/devtools/front_end/timeline/TimelineUIUtils.js
index c5aae0e60da6be2f59b334683c5d5da8d6bcd7d4..750b5470c4c9e3651d628b4fe800a1e08e440c4f 100644
--- a/Source/devtools/front_end/timeline/TimelineUIUtils.js
+++ b/Source/devtools/front_end/timeline/TimelineUIUtils.js
@@ -30,9 +30,53 @@
*/
/**
+ * @constructor
*/
WebInspector.TimelineUIUtils = function() { }
+WebInspector.TimelineUIUtils.prototype = {
+ /**
+ * @param {!WebInspector.TimelineModel.Record} record
+ * @return {boolean}
+ */
+ isBeginFrame: function(record)
+ {
+ throw new Error("Not implemented.");
+ },
+ /**
+ * @param {!WebInspector.TimelineModel.Record} record
+ * @return {boolean}
+ */
+ isProgram: function(record)
+ {
+ throw new Error("Not implemented.");
+ },
+ /**
+ * @param {string} recordType
+ * @return {boolean}
+ */
+ isCoalescable: function(recordType)
+ {
+ throw new Error("Not implemented.");
+ },
+ /**
+ * @param {!WebInspector.TimelineModel.Record} record
+ * @return {?Object}
+ */
+ countersForRecord: function(record)
+ {
+ throw new Error("Not implemented.");
+ },
+ /**
+ * @param {!WebInspector.TimelineModel.Record} record
+ * @return {?Object}
+ */
+ highlightQuadForRecord: function(record)
+ {
+ throw new Error("Not implemented.");
+ }
+}
+
/**
* @return {!Object.<string, !WebInspector.TimelineCategory>}
*/
@@ -111,13 +155,6 @@ WebInspector.TimelineUIUtils._initRecordStyles = function()
return recordStyles;
}
-WebInspector.TimelineUIUtils.coalescableRecordTypes = {};
-WebInspector.TimelineUIUtils.coalescableRecordTypes[WebInspector.TimelineModel.RecordType.Layout] = 1;
-WebInspector.TimelineUIUtils.coalescableRecordTypes[WebInspector.TimelineModel.RecordType.Paint] = 1;
-WebInspector.TimelineUIUtils.coalescableRecordTypes[WebInspector.TimelineModel.RecordType.Rasterize] = 1;
-WebInspector.TimelineUIUtils.coalescableRecordTypes[WebInspector.TimelineModel.RecordType.DecodeImage] = 1;
-WebInspector.TimelineUIUtils.coalescableRecordTypes[WebInspector.TimelineModel.RecordType.ResizeImage] = 1;
-
/**
* @param {!WebInspector.TimelineModel.Record} record
* @return {!{title: string, category: !WebInspector.TimelineCategory}}

Powered by Google App Engine
This is Rietveld 408576698