Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1647)

Unified Diff: Source/devtools/front_end/timeline/TimelineView.js

Issue 344443007: Encapsulate implementation-specific timeline record handling in TimelineUIUtils (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/devtools/front_end/timeline/TimelineView.js
diff --git a/Source/devtools/front_end/timeline/TimelineView.js b/Source/devtools/front_end/timeline/TimelineView.js
index 9ea54b2e47d7ecc4861ab13d0862e3faafb9f3e2..bb952f8492fe753e1a05a93da817bb0a54b1fbe8 100644
--- a/Source/devtools/front_end/timeline/TimelineView.js
+++ b/Source/devtools/front_end/timeline/TimelineView.js
@@ -35,16 +35,17 @@
* @implements {WebInspector.TimelineModeView}
* @param {!WebInspector.TimelineModeViewDelegate} delegate
* @param {!WebInspector.TimelineModel} model
- * @param {!Object.<string, number>} coalescableRecordTypes
+ * @param {!WebInspector.TimelineUIUtils} uiUtils
*/
-WebInspector.TimelineView = function(delegate, model, coalescableRecordTypes)
+WebInspector.TimelineView = function(delegate, model, uiUtils)
{
WebInspector.HBox.call(this);
+ this._uiUtils = uiUtils;
this.element.classList.add("timeline-view");
this._delegate = delegate;
this._model = model;
- this._presentationModel = new WebInspector.TimelinePresentationModel(model, coalescableRecordTypes);
+ this._presentationModel = new WebInspector.TimelinePresentationModel(model, uiUtils);
this._calculator = new WebInspector.TimelineCalculator(model);
this._linkifier = new WebInspector.Linkifier();
this._frameStripByFrame = new Map();
@@ -833,7 +834,7 @@ WebInspector.TimelineView.prototype = {
return true;
this._highlightedQuadRecord = record;
- var quad = record.highlightQuad();
+ var quad = this._uiUtils.highlightQuadForRecord(record);
if (!quad)
return false;
record.target().domAgent().highlightQuad(quad, WebInspector.Color.PageHighlight.Content.toProtocolRGBA(), WebInspector.Color.PageHighlight.ContentOutline.toProtocolRGBA());
« no previous file with comments | « Source/devtools/front_end/timeline/TimelineUIUtilsImpl.js ('k') | Source/devtools/front_end/timeline/TracingTimelineModel.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698