Use new common utils where possible.

Use new common utils where possible.

BUG=skia:2682
R=rmistry@google.com

Committed: https://skia.googlesource.com/buildbot/+/dd42159

[borenet, 2014-06-20 20:40:07]

Okay, I think this should work on most, if not all, of our bots.  Here's the
problem: as long as we maintain a utils directory in slave/skia_slave_scripts,
we can't add common/py to PYTHONPATH and "from utils import ...".  Additionally,
since third_party/chromium_buildbot/scripts/common exists, we can't add the root
directory to PYTHONPATH and "from common.py.utils import ...".  So the remaining
option was to add common to PYTHONPATH and "from py.utils import ...".

I grep'd for the filenames which moved and adjusted their imports appropriately.
 Then I tested on a LOT of platforms by running local bots.  I wasn't able to
test all of them.  The files I was NOT able to test were:

slave/skia_slave_scripts/check_buildslave_host_disk_usage.py
slave/skia_slave_scripts/chrome_drt_canary_upload_results.py
slave/skia_slave_scripts/do_auto_roll.py
slave/skia_slave_scripts/do_skps_capture.py
slave/skia_slave_scripts/flavor_utils/arm64model_build_step_utils.py
slave/skia_slave_scripts/flavor_utils/valgrind_build_step_utils.py
slave/skia_slave_scripts/merge_into_android.py
slave/skia_slave_scripts/sync_android.py
slave/skia_slave_scripts/update_all_buildslave_checkouts.py
slave/skia_slave_scripts/update_all_slave_hosts.py
slave/skia_slave_scripts/update_skp_version.py
slave/skia_slave_scripts/upload_bench_results_appengine.py
slave/skia_slave_scripts/utils/upload_to_bucket.py
slave/skia_slave_scripts/webpages_playback.py

These account for a small percentage of bots.  Unfortunately, I also had some
trouble creating this CL locally.  Somehow I "lost" the commits on my branch and
had to attempt to recover them using "git reflog".  So hopefully this still
works.

I think this will have to happen over a weekend, since this has such breakage
potential.

[jcgregorio, 2014-06-23 16:31:12]

On 2014/06/20 20:40:07, borenet wrote:
> Okay, I think this should work on most, if not all, of our bots.  Here's the
> problem: as long as we maintain a utils directory in slave/skia_slave_scripts,
> we can't add common/py to PYTHONPATH and "from utils import ...". 
Additionally,
> since third_party/chromium_buildbot/scripts/common exists, we can't add the
root
> directory to PYTHONPATH and "from common.py.utils import ...".

Sadness.

>  So the remaining
> option was to add common to PYTHONPATH and "from py.utils import ...".

Well, that's not as bad as I thought it would turn out :-)

> 
> I grep'd for the filenames which moved and adjusted their imports
appropriately.
>  Then I tested on a LOT of platforms by running local bots.  I wasn't able to
> test all of them.  The files I was NOT able to test were:
> 
> slave/skia_slave_scripts/check_buildslave_host_disk_usage.py
> slave/skia_slave_scripts/chrome_drt_canary_upload_results.py
> slave/skia_slave_scripts/do_auto_roll.py
> slave/skia_slave_scripts/do_skps_capture.py
> slave/skia_slave_scripts/flavor_utils/arm64model_build_step_utils.py
> slave/skia_slave_scripts/flavor_utils/valgrind_build_step_utils.py
> slave/skia_slave_scripts/merge_into_android.py
> slave/skia_slave_scripts/sync_android.py
> slave/skia_slave_scripts/update_all_buildslave_checkouts.py
> slave/skia_slave_scripts/update_all_slave_hosts.py
> slave/skia_slave_scripts/update_skp_version.py
> slave/skia_slave_scripts/upload_bench_results_appengine.py
> slave/skia_slave_scripts/utils/upload_to_bucket.py
> slave/skia_slave_scripts/webpages_playback.py
> 
> These account for a small percentage of bots.  Unfortunately, I also had some
> trouble creating this CL locally.  Somehow I "lost" the commits on my branch
and
> had to attempt to recover them using "git reflog".  So hopefully this still
> works.
> 
> I think this will have to happen over a weekend, since this has such breakage
> potential.

[rmistry, 2014-06-23 16:35:46]

LGTM

[borenet, 2014-07-10 11:46:23]

Committed patchset #4 manually as rdd42159 (presubmit successful).