Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Side by Side Diff: slave/skia_slave_scripts/flavor_utils/xsan_build_step_utils.py

Issue 344183004: Use new common utils where possible. (Closed) Base URL: https://skia.googlesource.com/buildbot.git@master
Patch Set: rebase Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 #!/usr/bin/env python 1 #!/usr/bin/env python
2 # Copyright (c) 2013 The Chromium Authors. All rights reserved. 2 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
3 # Use of this source code is governed by a BSD-style license that can be 3 # Use of this source code is governed by a BSD-style license that can be
4 # found in the LICENSE file. 4 # found in the LICENSE file.
5 5
6 """ Utilities for ASAN,TSAN,etc. build steps. """ 6 """ Utilities for ASAN,TSAN,etc. build steps. """
7 7
8 from default_build_step_utils import DefaultBuildStepUtils 8 from default_build_step_utils import DefaultBuildStepUtils
9 from utils import shell_utils 9 from py.utils import shell_utils
10 10
11 import os 11 import os
12 12
13 class XsanBuildStepUtils(DefaultBuildStepUtils): 13 class XsanBuildStepUtils(DefaultBuildStepUtils):
14 def Compile(self, target): 14 def Compile(self, target):
15 # Run the xsan_build script. 15 # Run the xsan_build script.
16 os.environ['GYP_DEFINES'] = self._step.args['gyp_defines'] 16 os.environ['GYP_DEFINES'] = self._step.args['gyp_defines']
17 print 'GYP_DEFINES="%s"' % os.environ['GYP_DEFINES'] 17 print 'GYP_DEFINES="%s"' % os.environ['GYP_DEFINES']
18 cmd = [ 18 cmd = [
19 os.path.join('tools', 'xsan_build'), 19 os.path.join('tools', 'xsan_build'),
20 self._step.args['sanitizer'], 20 self._step.args['sanitizer'],
21 target, 21 target,
22 'BUILDTYPE=%s' % self._step.configuration, 22 'BUILDTYPE=%s' % self._step.configuration,
23 ] 23 ]
24 24
25 cmd.extend(self._step.default_make_flags) 25 cmd.extend(self._step.default_make_flags)
26 cmd.extend(self._step.make_flags) 26 cmd.extend(self._step.make_flags)
27 shell_utils.run(cmd) 27 shell_utils.run(cmd)
28 28
29 def RunFlavoredCmd(self, app, args): 29 def RunFlavoredCmd(self, app, args):
30 # New versions of ASAN run LSAN by default. We're not yet clean for that. 30 # New versions of ASAN run LSAN by default. We're not yet clean for that.
31 os.environ['ASAN_OPTIONS'] = 'detect_leaks=0' 31 os.environ['ASAN_OPTIONS'] = 'detect_leaks=0'
32 # Point TSAN at our suppressions file. 32 # Point TSAN at our suppressions file.
33 os.environ['TSAN_OPTIONS'] = 'suppressions=tools/tsan.supp' 33 os.environ['TSAN_OPTIONS'] = 'suppressions=tools/tsan.supp'
34 return shell_utils.run([self._PathToBinary(app)] + args) 34 return shell_utils.run([self._PathToBinary(app)] + args)
OLDNEW
« no previous file with comments | « slave/skia_slave_scripts/flavor_utils/valgrind_build_step_utils.py ('k') | slave/skia_slave_scripts/generate_doxygen.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698