Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Side by Side Diff: slave/skia_slave_scripts/detect_static_initializers.py

Issue 344183004: Use new common utils where possible. (Closed) Base URL: https://skia.googlesource.com/buildbot.git@master
Patch Set: rebase Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « slave/skia_slave_scripts/compare_gms.py ('k') | slave/skia_slave_scripts/do_auto_roll.py » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 #!/usr/bin/env python 1 #!/usr/bin/env python
2 # Copyright (c) 2013 The Chromium Authors. All rights reserved. 2 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
3 # Use of this source code is governed by a BSD-style license that can be 3 # Use of this source code is governed by a BSD-style license that can be
4 # found in the LICENSE file. 4 # found in the LICENSE file.
5 5
6 """ Detect static initializers in compiled Skia code. """ 6 """ Detect static initializers in compiled Skia code. """
7 7
8 from utils import shell_utils
9 from build_step import BuildStep, BuildStepWarning 8 from build_step import BuildStep, BuildStepWarning
9 from py.utils import shell_utils
10 import os 10 import os
11 import re 11 import re
12 import sys 12 import sys
13 import urllib2 13 import urllib2
14 14
15 15
16 DUMP_STATIC_INITIALIZERS_FILENAME = 'dump-static-initializers.py' 16 DUMP_STATIC_INITIALIZERS_FILENAME = 'dump-static-initializers.py'
17 DUMP_STATIC_INITIALIZERS_URL = ('http://src.chromium.org/svn/trunk/src/tools/' 17 DUMP_STATIC_INITIALIZERS_URL = ('http://src.chromium.org/svn/trunk/src/tools/'
18 + 'linux/' + DUMP_STATIC_INITIALIZERS_FILENAME) 18 + 'linux/' + DUMP_STATIC_INITIALIZERS_FILENAME)
19 19
(...skipping 29 matching lines...) Expand all
49 print 49 print
50 for result in results: 50 for result in results:
51 print ' %s: %d' % result 51 print ' %s: %d' % result
52 print 52 print
53 # TODO(borenet): Make this an error once we have no static initializers. 53 # TODO(borenet): Make this an error once we have no static initializers.
54 raise BuildStepWarning('Static initializers found!') 54 raise BuildStepWarning('Static initializers found!')
55 55
56 56
57 if '__main__' == __name__: 57 if '__main__' == __name__:
58 sys.exit(BuildStep.RunBuildStep(DetectStaticInitializers)) 58 sys.exit(BuildStep.RunBuildStep(DetectStaticInitializers))
OLDNEW
« no previous file with comments | « slave/skia_slave_scripts/compare_gms.py ('k') | slave/skia_slave_scripts/do_auto_roll.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698