slave/skia_slave_scripts/flavor_utils/valgrind_build_step_utils.py - Issue 344183004: Use new common utils where possible.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: slave/skia_slave_scripts/flavor_utils/valgrind_build_step_utils.py

Issue 344183004: Use new common utils where possible. (Closed) Base URL: https://skia.googlesource.com/buildbot.git@master

Patch Set: rebase Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « slave/skia_slave_scripts/flavor_utils/ssh_build_step_utils.py ('k') | slave/skia_slave_scripts/flavor_utils/xsan_build_step_utils.py » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 # Copyright (c) 2013 The Chromium Authors. All rights reserved.	1 # Copyright (c) 2013 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4	4

5 """ Utilities for Valgrind build steps. """	5 """ Utilities for Valgrind build steps. """

6	6

7 from default_build_step_utils import DefaultBuildStepUtils	7 from default_build_step_utils import DefaultBuildStepUtils

8 from utils import shell_utils	8 from py.utils import shell_utils

9	9

10 import os	10 import os

11	11

12	12

13 class ValgrindBuildStepUtils(DefaultBuildStepUtils):	13 class ValgrindBuildStepUtils(DefaultBuildStepUtils):

14 def __init__(self, build_step_instance):	14 def __init__(self, build_step_instance):

15 DefaultBuildStepUtils.__init__(self, build_step_instance)	15 DefaultBuildStepUtils.__init__(self, build_step_instance)

16 self._suppressions_file = os.path.join('tools', 'valgrind.supp')	16 self._suppressions_file = os.path.join('tools', 'valgrind.supp')

17	17

18 def RunFlavoredCmd(self, app, args):	18 def RunFlavoredCmd(self, app, args):

(...skipping 13 matching lines...) Expand all Loading...
32 make_cmd = 'make'	32 make_cmd = 'make'

33 if os.name == 'nt':	33 if os.name == 'nt':

34 make_cmd = 'make.bat'	34 make_cmd = 'make.bat'

35 cmd = [make_cmd,	35 cmd = [make_cmd,

36 target,	36 target,

37 'BUILDTYPE=%s' % self._step.configuration,	37 'BUILDTYPE=%s' % self._step.configuration,

38 ]	38 ]

39 cmd.extend(self._step.default_make_flags)	39 cmd.extend(self._step.default_make_flags)

40 cmd.extend(self._step.make_flags)	40 cmd.extend(self._step.make_flags)

41 shell_utils.run(cmd)	41 shell_utils.run(cmd)

OLD	NEW