Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issue 343433009: Revert or Reland Window Control Animations for TouchView (Closed)

Created:
6 years, 6 months ago by jonross
Modified:
6 years, 6 months ago
Reviewers:
flackr
CC:
chromium-reviews, kalyank, sadrul, ben+ash_chromium.org, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Reland Window Control Animations for TouchView. (https://codereview.chromium.org/316693002/) Reason for revert: In Immersice Fullscreen, when a mouse hovers near the top of the screen the header animates in. This is done by animating TopContainerView. However this view does not contain all of the title bar, and forces a paint to its canvas. With FrameCaptionButtonContainerView painting to a layer it no longer paints to the canvas of TopContainerView. Due to z-order of the views FrameCaptionButtonContainer exists below the TopContainerView as well as below the ClientView of the browser. Reverting the use of layers in M37. For M38 the use of layers can be rexamined, however changes to the header views, or how immersive mode renders, will be needed before relanding this. Original issue's description: > Reland Window Control Animations for TouchView > > The original change contained a use-after-free bug. This was caused by window crossfade animation during > maximizing, combined with input event processing. The crossfade would take the current layer and delete it. > However the next input event to the window tree would attempt to access the now deleted layer. > Original Code Review: https://codereview.chromium.org/271913002/ > Revert Review: https://codereview.chromium.org/309973002/ > Revert "Revert of Animate window control changes in TouchView (https://codereview.chromium.org/271913002/)" > This reverts commit 8863218a5e97c4914a5a03df59e9d5d17f53a2cb. > > TBR=jamescook@chromium.org > TEST=FrameCaptionButtonContainerViewTest.AnimationUpdatesLayerTree > BUG=363717 > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276782 TBR=jamescook@chromium.org BUG=384612, 363717 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278520

Patch Set 1 #

Messages

Total messages: 6 (0 generated)
jonross
Hi Rob, This review is to revert a landed patch, in order to address a ...
6 years, 6 months ago (2014-06-19 17:42:39 UTC) #1
jonross
Updated the comment to follow the style of drover.
6 years, 6 months ago (2014-06-19 18:18:48 UTC) #2
flackr
LGTM
6 years, 6 months ago (2014-06-19 18:21:15 UTC) #3
jonross
The CQ bit was checked by jonross@chromium.org
6 years, 6 months ago (2014-06-19 18:23:10 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jonross@chromium.org/343433009/1
6 years, 6 months ago (2014-06-19 18:27:58 UTC) #5
commit-bot: I haz the power
6 years, 6 months ago (2014-06-19 22:50:48 UTC) #6
Message was sent while issue was closed.
Change committed as 278520

Powered by Google App Engine
This is Rietveld 408576698