Issue 342020: First of several patches to get rid of MessageLoop caching now that we have C...

Issue 342020: First of several patches to get rid of MessageLoop caching now that we have C... (Closed)

Created:
11 years, 1 month ago by jam

Modified:
9 years, 7 months ago

Reviewers:
tony

CC:
chromium-reviews_googlegroups.com, brettw+cc_chromium.org, ben+cc_chromium.org, Paul Godavari, jam, Paweł Hajdan Jr., darin (slow to review)

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

First of several patches to get rid of MessageLoop caching now that we have ChromeThread::PostTask. BUG=25354 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30383

Patch Set 2 : '' #

Total comments: 2

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+153 lines, -151 lines)			Patch
M	chrome/browser/automation/automation_profile_impl.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/automation/automation_provider.cc	View		2 chunks	+3 lines, -1 line	0 comments	Download
M	chrome/browser/browser_process.h	View		1 chunk	+5 lines, -1 line	0 comments	Download
M	chrome/browser/cocoa/web_drop_target_unittest.mm	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/dom_ui/downloads_dom_handler.cc	View		2 chunks	+3 lines, -1 line	0 comments	Download
M	chrome/browser/dom_ui/downloads_ui.cc	View		2 chunks	+3 lines, -2 lines	0 comments	Download
M	chrome/browser/dom_ui/filebrowse_ui.cc	View		3 chunks	+11 lines, -7 lines	0 comments	Download
M	chrome/browser/dom_ui/history_ui.cc	View		3 chunks	+11 lines, -7 lines	0 comments	Download
M	chrome/browser/dom_ui/most_visited_handler.cc	View		2 chunks	+12 lines, -14 lines	0 comments	Download
M	chrome/browser/dom_ui/new_tab_ui.cc	View		4 chunks	+19 lines, -20 lines	0 comments	Download
M	chrome/browser/dom_ui/print_ui.cc	View		2 chunks	+5 lines, -3 lines	0 comments	Download
M	chrome/browser/download/download_file.h	View		4 chunks	+2 lines, -15 lines	0 comments	Download
M	chrome/browser/download/download_file.cc	View		25 chunks	+62 lines, -69 lines	0 comments	Download
M	chrome/browser/renderer_host/download_resource_handler.cc	View		4 chunks	+9 lines, -6 lines	0 comments	Download
M	chrome/browser/renderer_host/resource_dispatcher_host.cc	View	1	2 chunks	+1 line, -2 lines	0 comments	Download
M	chrome/browser/renderer_host/test/test_render_view_host.h	View	1	2 chunks	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/renderer_host/test/test_render_view_host.cc	View		1 chunk	+2 lines, -0 lines	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

tony

LGTM, just a question about test_render_view_host.* http://codereview.chromium.org/342020/diff/4019/3015 File chrome/browser/renderer_host/test/test_render_view_host.cc (right): http://codereview.chromium.org/342020/diff/4019/3015#newcode108 Line 108: user_data_manager_.reset(UserDataManager::Create()); Is ...

11 years, 1 month ago (2009-10-28 20:27:33 UTC) #2

jam

11 years, 1 month ago (2009-10-28 20:31:08 UTC) #3

http://codereview.chromium.org/342020/diff/4019/3015
File chrome/browser/renderer_host/test/test_render_view_host.cc (right):

http://codereview.chromium.org/342020/diff/4019/3015#newcode108
Line 108: user_data_manager_.reset(UserDataManager::Create());
On 2009/10/28 20:27:33, tony wrote:
> Is this supposed to be in this change?

Yeah, this is needed because of the change to new_tab_ui.cc, specifically taking
out "if (g_browser_process->io_thread()) {".  Now we create NewTabHTMLSource
which internally uses the UserDataManager.  This occurs in a bunch of tests that
use RenderViewHostTestHarness.

Expand Messages | Collapse Messages