Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(345)

Unified Diff: chrome/browser/browser_process.h

Issue 342020: First of several patches to get rid of MessageLoop caching now that we have C... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/browser_process.h
===================================================================
--- chrome/browser/browser_process.h (revision 30289)
+++ chrome/browser/browser_process.h (working copy)
@@ -71,7 +71,11 @@
// Returns the thread that we perform I/O coordination on (network requests,
// communication with renderers, etc.
- // NOTE: need to check the return value for NULL.
+ // NOTE: You should ONLY use this to pass to IPC or other objects which must
+ // need a MessageLoop*. If you just want to post a task, use
+ // ChromeThread::PostTask (or other variants) as they take care of checking
+ // that a thread is still alive, race conditions, lifetime differences etc.
+ // If you still must use this, need to check the return value for NULL.
virtual base::Thread* io_thread() = 0;
// Returns the thread that we perform random file operations on. For code

Powered by Google App Engine
This is Rietveld 408576698