Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1480)

Unified Diff: chrome/browser/dom_ui/new_tab_ui.cc

Issue 342020: First of several patches to get rid of MessageLoop caching now that we have C... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/dom_ui/new_tab_ui.cc
===================================================================
--- chrome/browser/dom_ui/new_tab_ui.cc (revision 30289)
+++ chrome/browser/dom_ui/new_tab_ui.cc (working copy)
@@ -18,7 +18,7 @@
#include "base/string_piece.h"
#include "base/thread.h"
#include "chrome/browser/browser.h"
-#include "chrome/browser/browser_process.h"
+#include "chrome/browser/chrome_thread.h"
#include "chrome/browser/dom_ui/dom_ui_theme_source.h"
#include "chrome/browser/dom_ui/most_visited_handler.h"
#include "chrome/browser/dom_ui/new_tab_page_sync_handler.h"
@@ -548,9 +548,10 @@
IncognitoTabHTMLSource* html_source = new IncognitoTabHTMLSource(
GetProfile()->GetPrefs()->GetBoolean(prefs::kShowBookmarkBar));
-
- g_browser_process->io_thread()->message_loop()->PostTask(FROM_HERE,
- NewRunnableMethod(&chrome_url_data_manager,
+ ChromeThread::PostTask(
+ ChromeThread::IO, FROM_HERE,
+ NewRunnableMethod(
+ &chrome_url_data_manager,
&ChromeURLDataManager::AddDataSource,
html_source));
} else {
@@ -569,15 +570,14 @@
AddMessageHandler((new NewTabPageSetHomepageHandler())->Attach(this));
- // In testing mode there may not be an I/O thread.
- if (g_browser_process->io_thread()) {
- InitializeCSSCaches();
- NewTabHTMLSource* html_source = new NewTabHTMLSource(GetProfile());
- g_browser_process->io_thread()->message_loop()->PostTask(FROM_HERE,
- NewRunnableMethod(&chrome_url_data_manager,
- &ChromeURLDataManager::AddDataSource,
- html_source));
- }
+ InitializeCSSCaches();
+ NewTabHTMLSource* html_source = new NewTabHTMLSource(GetProfile());
+ ChromeThread::PostTask(
+ ChromeThread::IO, FROM_HERE,
+ NewRunnableMethod(
+ &chrome_url_data_manager,
+ &ChromeURLDataManager::AddDataSource,
+ html_source));
}
// Listen for theme installation.
@@ -614,13 +614,12 @@
}
void NewTabUI::InitializeCSSCaches() {
- // In testing mode there may not be an I/O thread.
- if (g_browser_process->io_thread()) {
- g_browser_process->io_thread()->message_loop()->PostTask(FROM_HERE,
- NewRunnableMethod(&chrome_url_data_manager,
- &ChromeURLDataManager::AddDataSource,
- new DOMUIThemeSource(GetProfile())));
- }
+ ChromeThread::PostTask(
+ ChromeThread::IO, FROM_HERE,
+ NewRunnableMethod(
+ &chrome_url_data_manager,
+ &ChromeURLDataManager::AddDataSource,
+ new DOMUIThemeSource(GetProfile())));
}
// static

Powered by Google App Engine
This is Rietveld 408576698