Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2173)

Unified Diff: chrome/browser/download/download_file.h

Issue 342020: First of several patches to get rid of MessageLoop caching now that we have C... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/download/download_file.h
===================================================================
--- chrome/browser/download/download_file.h (revision 30289)
+++ chrome/browser/download/download_file.h (working copy)
@@ -60,7 +60,6 @@
}
struct DownloadCreateInfo;
class DownloadManager;
-class MessageLoop;
class ResourceDispatcherHost;
class URLRequestContextGetter;
@@ -168,11 +167,10 @@
class DownloadFileManager
: public base::RefCountedThreadSafe<DownloadFileManager> {
public:
- DownloadFileManager(MessageLoop* ui_loop, ResourceDispatcherHost* rdh);
+ DownloadFileManager(ResourceDispatcherHost* rdh);
~DownloadFileManager();
- // Lifetime management functions, called on the UI thread.
- void Initialize();
+ // Called on shutdown on the UI thread.
void Shutdown();
// Called on the IO thread
@@ -232,8 +230,6 @@
// Timer notifications.
void UpdateInProgressDownloads();
- MessageLoop* file_loop() const { return file_loop_; }
-
// Called by the download manager to delete non validated dangerous downloads.
static void DeleteFile(const FilePath& path);
@@ -266,15 +262,6 @@
// Throttle updates to the UI thread.
base::RepeatingTimer<DownloadFileManager> update_timer_;
- // The MessageLoop that the DownloadManagers live on.
- MessageLoop* ui_loop_;
-
- // The MessageLoop that the this objects primarily operates on.
- MessageLoop* file_loop_;
-
- // Used only for DCHECKs!
- MessageLoop* io_loop_;
-
ResourceDispatcherHost* resource_dispatcher_host_;
// Tracking which DownloadManager to send data to, called only on UI thread.

Powered by Google App Engine
This is Rietveld 408576698