Revert 277929 "[fsp] Cleanup handling errors for operation reque..."

Revert 277929 "[fsp] Cleanup handling errors for operation reque..."

> [fsp] Cleanup handling errors for operation requests.
> 
> This CL removes redundant internal functions which are identical, and replaces
> them with one.
> 
> Moreover, the new general purpose error API function, passes now the entire
> value to the request manager. This is because, very soon, we are going to
> pass extra information with every error and success responses and we want to
> have access to them in the RequestManager.
> 
> NOTRY=true
> TEST=unit_tests, browser_tests: *FileSystemProvider*
> BUG=373165, 384201
> 
> Review URL: https://codereview.chromium.org/335753004

TBR=mtomasz@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278186

[oshima, 2014-06-18 22:23:33]

Committed patchset #1 manually as r278186 (tree was closed).

[oshima, 2014-06-18 22:25:53]

On 2014/06/18 22:23:33, oshima wrote:
> Committed patchset #1 manually as r278186 (tree was closed).

reason for revert. chromeos asan bot failures.

http://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20...

[ RUN      ] FileSystemProviderApiTest.GetMetadata
[4789:4789:0617/204551:2710910301:WARNING:diagnostics_writer.cc(214)] [FAIL] 014
PathUserData (Cannot obtain size for:
/tmp/.org.chromium.Chromium.XBpmt7/dBns8vW)
[4789:4789:0617/204551:2710910529:WARNING:diagnostics_writer.cc(214)] [FAIL] 013
PathLocalState (Path not found: /tmp/.org.chromium.Chromium.XBpmt7/dBns8vW/Local
State)
[4789:4789:0617/204551:2710911197:WARNING:diagnostics_writer.cc(214)] [FAIL] 019
JSONPreferences (File not found)
[4789:4789:0617/204551:2710911263:WARNING:diagnostics_writer.cc(214)] [FAIL] 019
JSONLocalState (File not found)
[4789:4789:0617/204551:2710911365:WARNING:diagnostics_writer.cc(214)] [FAIL] 002
SQLiteIntegrityWebData (File not found)
[4789:4789:0617/204551:2710911430:WARNING:diagnostics_writer.cc(214)] [FAIL] 002
SQLiteIntegrityCookie (File not found)
[4789:4789:0617/204551:2710911487:WARNING:diagnostics_writer.cc(214)] [FAIL] 002
SQLiteIntegrityHistory (File not found)
[4789:4789:0617/204555:2714667168:WARNING:diagnostics_writer.cc(214)] Finished
18 tests.
[4789:4789:0617/204555:2714667353:WARNING:diagnostics_writer.cc(214)] Finished
Recovery for: Install type
[4789:4789:0617/204555:2714667411:WARNING:diagnostics_writer.cc(214)] Finished
Recovery for: Chrome version test
[4789:4789:0617/204555:2714667466:WARNING:diagnostics_writer.cc(214)] Finished
Recovery for: User data path
[4789:4789:0617/204555:2714667514:WARNING:diagnostics_writer.cc(214)] Finished
Recovery for: Local state path
[4789:4789:0617/204555:2714667561:WARNING:diagnostics_writer.cc(214)] Finished
Recovery for: App dictionaries directory path
[4789:4789:0617/204555:2714667635:WARNING:diagnostics_writer.cc(214)] Finished
Recovery for: Resources path
[4789:4789:0617/204555:2714667690:WARNING:diagnostics_writer.cc(214)] Finished
Recovery for: Available disk space
[4789:4789:0617/204555:2714667754:WARNING:diagnostics_writer.cc(214)] Finished
Recovery for: User preferences integrity
[4789:4789:0617/204555:2714667805:WARNING:diagnostics_writer.cc(214)] Finished
Recovery for: Local state integrity
[4789:4789:0617/204555:2714667851:WARNING:diagnostics_writer.cc(214)] Finished
Recovery for: Bookmark file
[4789:4789:0617/204555:2714667911:WARNING:diagnostics_writer.cc(214)] Finished
Recovery for: Web Data database
[4789:4789:0617/204555:2714667962:WARNING:diagnostics_writer.cc(214)] Finished
Recovery for: Cookie database
[4789:4789:0617/204555:2714668072:WARNING:diagnostics_writer.cc(214)] Finished
Recovery for: History database
[4789:4789:0617/204555:2714668136:WARNING:diagnostics_writer.cc(214)] Finished
Recovery for: Archived history database
[4789:4789:0617/204555:2714668206:WARNING:diagnostics_writer.cc(214)] Finished
Recovery for: Thumbnails database
[4789:4789:0617/204555:2714668256:WARNING:diagnostics_writer.cc(214)] Finished
Recovery for: Database tracker database
<truncated, full output is in gzipped JSON output at end of step>
    #46 0xdc06a12 in content::BrowserTestBase::SetUp()
content/public/test/browser_test_base.cc:252
    #47 0x38b5ac2 in InProcessBrowserTest::SetUp()
chrome/test/base/in_process_browser_test.cc:210
    #48 0x42fd101 in HandleExceptionsInMethodIfSupported\u003Ctesting::Test,
void> testing/gtest/src/gtest.cc:2045
    #49 0x42fd101 in testing::Test::Run() testing/gtest/src/gtest.cc:2057
    #50 0x42ff398 in testing::TestInfo::Run() testing/gtest/src/gtest.cc:2237
    #51 0x43000d6 in testing::TestCase::Run() testing/gtest/src/gtest.cc:2344
    #52 0x4312dba in testing::internal::UnitTestImpl::RunAllTests()
testing/gtest/src/gtest.cc:4065
    #53 0x4312400 in
HandleExceptionsInMethodIfSupported\u003Ctesting::internal::UnitTestImpl, bool>
testing/gtest/src/gtest.cc:2045
    #54 0x4312400 in testing::UnitTest::Run() testing/gtest/src/gtest.cc:3697
    #55 0x3a54264 in RUN_ALL_TESTS testing/gtest/include/gtest/gtest.h:2231
    #56 0x3a54264 in base::TestSuite::Run() base/test/test_suite.cc:227
    #57 0x259e1c6 in ChromeBrowserTestSuiteRunner::RunTestSuite(int, char**)
chrome/test/base/browser_tests_main.cc:14
    #58 0xdc83b1d in content::LaunchTests(content::TestLauncherDelegate*, int,
int, char**) content/public/test/test_launcher.cc:468
    #59 0x38b2b89 in LaunchChromeTests(int, ChromeTestSuiteRunner*, int, char**)
chrome/test/base/chrome_test_launcher.cc:129
    #60 0x259e0da in main chrome/test/base/browser_tests_main.cc:21
    #61 0x7fe19564576c in __libc_start_main
/build/buildd/eglibc-2.15/csu/libc-start.c:226
    #62 0x5a579c in _start
(/mnt/data/b/build/slave/Linux_Chromium_OS_ASan_LSan_Tests__2_/build/src/out/Release/browser_tests+0x5a579c)

AddressSanitizer can not provide additional info.
SUMMARY: AddressSanitizer: SEGV
chrome/browser/chromeos/extensions/file_system_provider/file_system_provider_api.cc:163
extensions::FileSystemProviderInternalOperationRequestedErrorFunction::RunWhenValid()
Cannot upload crash dump: failed to open
==4789==ABORTING
[0617/204600:ERROR:nacl_helper_linux.cc(277)] NaCl helper process running
without a sandbox!
Most likely you need to configure your SUID sandbox correctly


and two others. see the link above.