Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Unified Diff: trunk/src/chrome/browser/chromeos/file_system_provider/operations/read_directory_unittest.cc

Issue 342003004: Revert 277929 "[fsp] Cleanup handling errors for operation reque..." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: trunk/src/chrome/browser/chromeos/file_system_provider/operations/read_directory_unittest.cc
===================================================================
--- trunk/src/chrome/browser/chromeos/file_system_provider/operations/read_directory_unittest.cc (revision 278185)
+++ trunk/src/chrome/browser/chromeos/file_system_provider/operations/read_directory_unittest.cc (working copy)
@@ -171,6 +171,7 @@
}
TEST_F(FileSystemProviderOperationsReadDirectoryTest, OnSuccess) {
+ using extensions::api::file_system_provider::EntryMetadata;
using extensions::api::file_system_provider_internal::
ReadDirectoryRequestedSuccess::Params;
@@ -241,6 +242,10 @@
}
TEST_F(FileSystemProviderOperationsReadDirectoryTest, OnError) {
+ using extensions::api::file_system_provider::EntryMetadata;
+ using extensions::api::file_system_provider_internal::
+ ReadDirectoryRequestedSuccess::Params;
+
LoggingDispatchEventImpl dispatcher(true /* dispatch_reply */);
CallbackLogger callback_logger;
@@ -255,9 +260,7 @@
EXPECT_TRUE(read_directory.Execute(kRequestId));
- read_directory.OnError(kRequestId,
- scoped_ptr<RequestValue>(new RequestValue()),
- base::File::FILE_ERROR_TOO_MANY_OPENED);
+ read_directory.OnError(kRequestId, base::File::FILE_ERROR_TOO_MANY_OPENED);
ASSERT_EQ(1u, callback_logger.events().size());
CallbackLogger::Event* event = callback_logger.events()[0];

Powered by Google App Engine
This is Rietveld 408576698