Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(356)

Unified Diff: trunk/src/chrome/common/extensions/api/file_system_provider_internal.idl

Issue 342003004: Revert 277929 "[fsp] Cleanup handling errors for operation reque..." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: trunk/src/chrome/common/extensions/api/file_system_provider_internal.idl
===================================================================
--- trunk/src/chrome/common/extensions/api/file_system_provider_internal.idl (revision 278185)
+++ trunk/src/chrome/common/extensions/api/file_system_provider_internal.idl (working copy)
@@ -13,6 +13,13 @@
static void unmountRequestedSuccess(DOMString fileSystemId,
long requestId);
+ // Internal. Error callback of the <code>onUnmountRequested</code>
+ // event. Must be called if unmounting fails.
+ static void unmountRequestedError(
+ DOMString fileSystemId,
+ long requestId,
+ fileSystemProvider.ProviderError error);
+
// Internal. Success callback of the <code>onGetMetadataRequested</code>
// event. Must be called if metadata is available.
static void getMetadataRequestedSuccess(
@@ -20,6 +27,13 @@
long requestId,
fileSystemProvider.EntryMetadata metadata);
+ // Internal. Error callback of the <code>onGetMetadataRequested</code>
+ // event. Must be called when obtaining metadata fails.
+ static void getMetadataRequestedError(
+ DOMString fileSystemId,
+ long requestId,
+ fileSystemProvider.ProviderError error);
+
// Internal. Success callback of the <code>onReadDirectoryRequested</code>
// event. Can be called multiple times per request.
static void readDirectoryRequestedSuccess(
@@ -28,18 +42,39 @@
fileSystemProvider.EntryMetadata[] entries,
boolean hasMore);
+ // Internal. Error callback of the <code>onReadDirectoryRequested</code>
+ // event. Must be called when reading a directory fails.
+ static void readDirectoryRequestedError(
+ DOMString fileSystemId,
+ long requestId,
+ fileSystemProvider.ProviderError error);
+
// Internal. Success callback of the <code>onOpenFileRequested</code> event.
// Must be called, when opening succeeds.
static void openFileRequestedSuccess(
DOMString fileSystemId,
long requestId);
+ // Internal. Error callback of the <code>onOpenFileRequested</code> event.
+ // Must be called when opening fails.
+ static void openFileRequestedError(
+ DOMString fileSystemId,
+ long requestId,
+ fileSystemProvider.ProviderError error);
+
// Internal. Success callback of the <code>onCloseFileRequested</code>
// event. Must be called, when closing succeeds.
static void closeFileRequestedSuccess(
DOMString fileSystemId,
long requestId);
+ // Internal. Error callback of the <code>onCloseFileRequested</code> event.
+ // Must be called when closing fails.
+ static void closeFileRequestedError(
+ DOMString fileSystemId,
+ long requestId,
+ fileSystemProvider.ProviderError error);
+
// Internal. Success callback of the <code>onReadFileRequested</code>
// event. Can be called multiple times per request.
static void readFileRequestedSuccess(
@@ -48,13 +83,12 @@
ArrayBuffer data,
boolean hasMore);
- // Internal. Error callback of all of the operation requests. Must be called
- // if an operation fails.
- static void operationRequestedError(
+ // Internal. Error callback of the <code>onReadFileRequested</code>
+ // event. Must be called when reading a file fails.
+ static void readFileRequestedError(
DOMString fileSystemId,
long requestId,
fileSystemProvider.ProviderError error);
-
};
};

Powered by Google App Engine
This is Rietveld 408576698