[fsp] Cleanup handling errors for operation requests.

[fsp] Cleanup handling errors for operation requests.

This CL removes redundant internal functions which are identical, and replaces
them with one.

Moreover, the new general purpose error API function, passes now the entire
value to the request manager. This is because, very soon, we are going to
pass extra information with every error and success responses and we want to
have access to them in the RequestManager.

NOTRY=true
TEST=unit_tests, browser_tests: *FileSystemProvider*
BUG=373165, 384201
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277929

[mtomasz, 2014-06-13 03:46:28]

@benwells: PTAL at IDL.
@kinaba: PTAL at C++.

This is a mechanical change. Removing redundant API functions and adding an
RequestValue argument to the RequestManager::RejectRequest, and
RequestManager::HandlerInterface::OnError.

Thanks.

[benwells, 2014-06-16 03:09:06]

idl and custom bindings lgtm

[kinaba, 2014-06-16 03:16:16]

lgtm

[mtomasz, 2014-06-16 03:30:05]

The CQ bit was checked by mtomasz@chromium.org

[commit-bot: I haz the power, 2014-06-16 03:30:21]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mtomasz@chromium.org/335753004/20001

[commit-bot: I haz the power, 2014-06-16 04:05:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-16 04:05:01]

Try jobs failed on following builders:
  ios_rel_device_ninja on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device_ninja/...)
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/17041)

[mtomasz, 2014-06-16 04:25:11]

The CQ bit was checked by mtomasz@chromium.org

[commit-bot: I haz the power, 2014-06-16 04:25:59]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mtomasz@chromium.org/335753004/30001

[mtomasz, 2014-06-16 06:53:06]

@isherman: PTAL at histograms. Thanks.

[commit-bot: I haz the power, 2014-06-16 07:36:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-16 07:36:45]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)

[Ilya Sherman, 2014-06-16 21:06:15]

Please run the script to update histograms.xml.

[mtomasz, 2014-06-17 02:46:38]

On 2014/06/16 21:06:15, Ilya Sherman wrote:
> Please run the script to update histograms.xml.

Done. PTAL.

[Ilya Sherman, 2014-06-17 03:04:31]

histograms lgtm, thanks

[mtomasz, 2014-06-17 03:04:51]

On 2014/06/17 03:04:31, Ilya Sherman wrote:
> histograms lgtm, thanks

Thanks!

[mtomasz, 2014-06-17 03:04:57]

The CQ bit was checked by mtomasz@chromium.org

[commit-bot: I haz the power, 2014-06-17 03:08:08]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mtomasz@chromium.org/335753004/50001

[commit-bot: I haz the power, 2014-06-17 09:29:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-17 09:29:59]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)

[mtomasz, 2014-06-17 12:12:19]

The CQ bit was checked by mtomasz@chromium.org

[commit-bot: I haz the power, 2014-06-17 12:13:09]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mtomasz@chromium.org/335753004/50001

[commit-bot: I haz the power, 2014-06-17 12:14:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-17 12:14:27]

Failed to apply patch for
extensions/browser/extension_function_histogram_value.h:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file extensions/browser/extension_function_histogram_value.h
  Hunk #4 FAILED at 849.
  1 out of 4 hunks FAILED -- saving rejects to file
extensions/browser/extension_function_histogram_value.h.rej

Patch:       extensions/browser/extension_function_histogram_value.h
Index: extensions/browser/extension_function_histogram_value.h
diff --git a/extensions/browser/extension_function_histogram_value.h
b/extensions/browser/extension_function_histogram_value.h
index
291fd10c4fd2a324dfd07b333278e52fa88cd6cf..422270e1b99c277be406d0db85cfad0e0f2a6952
100644
--- a/extensions/browser/extension_function_histogram_value.h
+++ b/extensions/browser/extension_function_histogram_value.h
@@ -776,7 +776,7 @@ enum HistogramValue {
   DELETED_BLUETOOTH_GET_SOCKETS,
   FILESYSTEMPROVIDER_UNMOUNT,
   FILESYSTEMPROVIDERINTERNAL_UNMOUNTREQUESTEDSUCCESS,
-  FILESYSTEMPROVIDERINTERNAL_UNMOUNTREQUESTEDERROR,
+  DELETED_FILESYSTEMPROVIDERINTERNAL_UNMOUNTREQUESTEDERROR,
   MEDIAGALLERIES_DROPPERMISSIONFORMEDIAFILESYSTEM,
   WEBCAMPRIVATE_SET,
   WEBCAMPRIVATE_RESET,
@@ -809,7 +809,7 @@ enum HistogramValue {
   WEBSTOREPRIVATE_SIGNINFUNCTION,
   SHELL_CREATEWINDOW,
   FILESYSTEMPROVIDERINTERNAL_GETMETADATAREQUESTEDSUCCESS,
-  FILESYSTEMPROVIDERINTERNAL_GETMETADATAREQUESTEDERROR,
+  DELETED_FILESYSTEMPROVIDERINTERNAL_GETMETADATAREQUESTEDERROR,
   BROWSER_OPENTAB,
   MANAGEMENT_CREATEAPPSHORTCUT,
   WEBVIEW_SHOWCONTEXTMENU,
@@ -819,19 +819,19 @@ enum HistogramValue {
   HOTWORDPRIVATE_SETHOTWORDSESSIONSTATE,
   HOTWORDPRIVATE_NOTIFYHOTWORDRECOGNITION,
   FILESYSTEMPROVIDERINTERNAL_READDIRECTORYREQUESTEDSUCCESS,
-  FILESYSTEMPROVIDERINTERNAL_READDIRECTORYREQUESTEDERROR,
+  DELETED_FILESYSTEMPROVIDERINTERNAL_READDIRECTORYREQUESTEDERROR,
   LEDGER_BATCHEXECUTE,
   FILESYSTEMPROVIDERINTERNAL_OPENFILEREQUESTEDSUCCESS,
-  FILESYSTEMPROVIDERINTERNAL_OPENFILEREQUESTEDERROR,
+  DELETED_FILESYSTEMPROVIDERINTERNAL_OPENFILEREQUESTEDERROR,
   FILESYSTEMPROVIDERINTERNAL_CLOSEFILEREQUESTEDSUCCESS,
-  FILESYSTEMPROVIDERINTERNAL_CLOSEFILEREQUESTEDERROR,
+  DELETED_FILESYSTEMPROVIDERINTERNAL_CLOSEFILEREQUESTEDERROR,
   SYNCEDNOTIFICATIONSPRIVATE_GETINITIALDATA,
   SYNCEDNOTIFICATIONSPRIVATE_UPDATENOTIFICATION,
   SYNCEDNOTIFICATIONSPRIVATE_SETRENDERCONTEXT,
   IDENTITY_GETACCOUNTS,
   FILEBROWSERPRIVATE_RESOLVEISOLATEDENTRIES,
   FILESYSTEMPROVIDERINTERNAL_READFILEREQUESTEDSUCCESS,
-  FILESYSTEMPROVIDERINTERNAL_READFILEREQUESTEDERROR,
+  DELETED_FILESYSTEMPROVIDERINTERNAL_READFILEREQUESTEDERROR,
   NETWORKINGPRIVATE_GETNETWORKS,
   WEBVIEW_SETNAME,
   ENTERPRISE_PLATFORMKEYSINTERNAL_GENERATEKEY,
@@ -849,6 +849,7 @@ enum HistogramValue {
   INPUTMETHODPRIVATE_GETCURRENTINPUTMETHOD,
   INPUTMETHODPRIVATE_SETCURRENTINPUTMETHOD,
   INPUTMETHODPRIVATE_GETINPUTMETHODS,
+  FILESYSTEMPROVIDERINTERNAL_OPERATIONREQUESTEDERROR,
   // Last entry: Add new entries above and ensure to update
   // tools/metrics/histograms/histograms/histograms.xml.
   ENUM_BOUNDARY

[mtomasz, 2014-06-18 00:40:53]

The CQ bit was checked by mtomasz@chromium.org

[commit-bot: I haz the power, 2014-06-18 00:42:17]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mtomasz@chromium.org/335753004/70001

[commit-bot: I haz the power, 2014-06-18 00:45:00]

Change committed as 277929

[please use gerrit instead, 2014-06-19 01:04:42]

This change broke on FileSystemProviderApiTest.GetMetadata,
FileSystemProviderApiTest.ReadDirectory, and FileSystemProviderApiTest.Unmount
on
http://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20...

Please re-land after running through the "linux_asan" try-bot. I will be
reverting manually because drover and rietveld cannot handle files larger than
~900KB (histograms.xml). Sorry for the inconvenience.

[please use gerrit instead, 2014-06-19 01:09:04]

Nevermind, already reverted in https://codereview.chromium.org/342003004/.

[mtomasz, 2014-06-19 01:09:31]

On 2014/06/19 01:04:42, Rouslan Solomakhin wrote:
> This change broke on FileSystemProviderApiTest.GetMetadata,
> FileSystemProviderApiTest.ReadDirectory, and FileSystemProviderApiTest.Unmount
> on
>
http://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20...
> 
> Please re-land after running through the "linux_asan" try-bot. I will be
> reverting manually because drover and rietveld cannot handle files larger than
> ~900KB (histograms.xml). Sorry for the inconvenience.

Already reverted:
https://codereview.chromium.org/342003004/