Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(273)

Issue 341103002: [New Multicolumn] Remove unnecessary calls to setRegionBasedColumnsEnabled. (Closed)

Created:
6 years, 6 months ago by andersr
Modified:
6 years, 5 months ago
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

[New Multicolumn] Remove unnecessary calls to setRegionBasedColumnsEnabled. Tests which enable region based multicolumn behavior using Javascript don't need to do that anymore, because they are run via virtual/regionbasedmulticol, which enables the new behavior using a command line flag. Note that tests in fast/multicol/newmulticol/compare-with-old-impl still need to call internals.settings.setRegionBasedColumnsEnabled(true). They are now the only tests which need to do so. (And it should remain like that until they are removed during Issue 350853). BUG=334335 R=rune@opera.com Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177528

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -294 lines) Patch
M LayoutTests/fast/multicol/balance-short-trailing-empty-block.html View 1 chunk +0 lines, -4 lines 0 comments Download
M LayoutTests/fast/multicol/balance-trailing-border.html View 1 chunk +0 lines, -4 lines 0 comments Download
M LayoutTests/fast/multicol/balance-trailing-border2.html View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/fast/multicol/balance-unbreakable.html View 1 chunk +0 lines, -4 lines 0 comments Download
M LayoutTests/fast/multicol/break-in-scrollable.html View 1 chunk +0 lines, -4 lines 0 comments Download
M LayoutTests/fast/multicol/break-in-scrollable-expected.html View 1 chunk +0 lines, -4 lines 0 comments Download
M LayoutTests/fast/multicol/change-block-child-height.html View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/fast/multicol/change-block-child-height-expected.html View 1 chunk +0 lines, -4 lines 0 comments Download
M LayoutTests/fast/multicol/change-height.html View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/fast/multicol/content-change-same-height.html View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/fast/multicol/cssom-view.html View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/fast/multicol/inline-children-crash.html View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/fast/multicol/inline-getclientrects.html View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/fast/multicol/mixed-opacity-fixed-test.html View 1 chunk +0 lines, -3 lines 0 comments Download
M LayoutTests/fast/multicol/mixed-opacity-test.html View 1 chunk +0 lines, -3 lines 0 comments Download
M LayoutTests/fast/multicol/mixed-positioning-stacking-order.html View 1 chunk +0 lines, -5 lines 0 comments Download
M LayoutTests/fast/multicol/newmulticol/avoid-column-break-inside.html View 1 chunk +0 lines, -4 lines 0 comments Download
M LayoutTests/fast/multicol/newmulticol/balance-images.html View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/fast/multicol/newmulticol/balance-maxheight1.html View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/fast/multicol/newmulticol/balance-maxheight2.html View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/fast/multicol/newmulticol/balance1.html View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/fast/multicol/newmulticol/balance10.html View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/fast/multicol/newmulticol/balance2.html View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/fast/multicol/newmulticol/balance3.html View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/fast/multicol/newmulticol/balance4.html View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/fast/multicol/newmulticol/balance5.html View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/fast/multicol/newmulticol/balance6.html View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/fast/multicol/newmulticol/balance7.html View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/fast/multicol/newmulticol/balance8.html View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/fast/multicol/newmulticol/balance9.html View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/fast/multicol/newmulticol/break-after.html View 1 chunk +0 lines, -4 lines 0 comments Download
M LayoutTests/fast/multicol/newmulticol/break-after-expected.html View 1 chunk +0 lines, -4 lines 0 comments Download
M LayoutTests/fast/multicol/newmulticol/break-before.html View 1 chunk +0 lines, -4 lines 0 comments Download
M LayoutTests/fast/multicol/newmulticol/breaks-2-columns-3.html View 1 chunk +0 lines, -4 lines 0 comments Download
M LayoutTests/fast/multicol/newmulticol/breaks-2-columns-3-no-balancing.html View 1 chunk +0 lines, -4 lines 0 comments Download
M LayoutTests/fast/multicol/newmulticol/breaks-3-columns-3.html View 1 chunk +0 lines, -4 lines 0 comments Download
M LayoutTests/fast/multicol/newmulticol/cell-shrinkback.html View 1 chunk +0 lines, -4 lines 0 comments Download
M LayoutTests/fast/multicol/newmulticol/clipping.html View 1 chunk +0 lines, -4 lines 0 comments Download
M LayoutTests/fast/multicol/newmulticol/clipping-expected.html View 1 chunk +0 lines, -4 lines 0 comments Download
M LayoutTests/fast/multicol/newmulticol/clipping-overflow-hidden.html View 1 chunk +0 lines, -4 lines 0 comments Download
M LayoutTests/fast/multicol/newmulticol/clipping-overflow-hidden-expected.html View 1 chunk +0 lines, -4 lines 0 comments Download
M LayoutTests/fast/multicol/newmulticol/clipping-top-overflow.html View 1 chunk +0 lines, -4 lines 0 comments Download
M LayoutTests/fast/multicol/newmulticol/clipping-top-overflow-expected.html View 1 chunk +0 lines, -4 lines 0 comments Download
M LayoutTests/fast/multicol/newmulticol/column-rules-fixed-height.html View 1 chunk +0 lines, -3 lines 0 comments Download
M LayoutTests/fast/multicol/newmulticol/direct-child-column-span-all.html View 1 chunk +0 lines, -5 lines 0 comments Download
M LayoutTests/fast/multicol/newmulticol/fixed-height-fill-auto.html View 1 chunk +0 lines, -4 lines 0 comments Download
M LayoutTests/fast/multicol/newmulticol/fixed-height-fill-auto-expected.html View 1 chunk +0 lines, -4 lines 0 comments Download
M LayoutTests/fast/multicol/newmulticol/fixed-height-fill-balance.html View 1 chunk +0 lines, -4 lines 0 comments Download
M LayoutTests/fast/multicol/newmulticol/fixed-height-fill-balance-2.html View 1 chunk +0 lines, -4 lines 0 comments Download
M LayoutTests/fast/multicol/newmulticol/fixed-height-fill-balance-expected.html View 1 chunk +0 lines, -4 lines 0 comments Download
M LayoutTests/fast/multicol/newmulticol/float-avoidance.html View 1 chunk +0 lines, -3 lines 0 comments Download
M LayoutTests/fast/multicol/newmulticol/float-multicol.html View 1 chunk +0 lines, -3 lines 0 comments Download
M LayoutTests/fast/multicol/newmulticol/float-paginate.html View 1 chunk +0 lines, -3 lines 0 comments Download
M LayoutTests/fast/multicol/newmulticol/float-paginate-complex.html View 1 chunk +0 lines, -3 lines 0 comments Download
M LayoutTests/fast/multicol/newmulticol/float-paginate-empty-lines.html View 1 chunk +0 lines, -3 lines 0 comments Download
M LayoutTests/fast/multicol/newmulticol/hide-box-horizontal-bt.html View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/fast/multicol/newmulticol/hide-box-horizontal-bt-expected.html View 1 chunk +0 lines, -4 lines 0 comments Download
M LayoutTests/fast/multicol/newmulticol/hide-box-vertical-lr.html View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/fast/multicol/newmulticol/hide-box-vertical-lr-expected.html View 1 chunk +0 lines, -4 lines 0 comments Download
M LayoutTests/fast/multicol/newmulticol/hide-box-vertical-rl.html View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/fast/multicol/newmulticol/hide-box-vertical-rl-expected.html View 1 chunk +0 lines, -4 lines 0 comments Download
M LayoutTests/fast/multicol/newmulticol/layers-in-multicol.html View 1 chunk +0 lines, -3 lines 0 comments Download
M LayoutTests/fast/multicol/newmulticol/layers-split-across-columns.html View 1 chunk +0 lines, -3 lines 0 comments Download
M LayoutTests/fast/multicol/newmulticol/leading-and-trailing-margin.html View 1 chunk +0 lines, -4 lines 0 comments Download
M LayoutTests/fast/multicol/newmulticol/leading-and-trailing-margin-expected.html View 1 chunk +0 lines, -4 lines 0 comments Download
M LayoutTests/fast/multicol/newmulticol/leading-margin.html View 1 chunk +0 lines, -4 lines 0 comments Download
M LayoutTests/fast/multicol/newmulticol/list-item.html View 1 chunk +0 lines, -4 lines 0 comments Download
M LayoutTests/fast/multicol/newmulticol/multicol-becomes-regular-block.html View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/fast/multicol/newmulticol/orphans-and-widows-balance.html View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/fast/multicol/newmulticol/positioned-split.html View 1 chunk +0 lines, -3 lines 0 comments Download
M LayoutTests/fast/multicol/newmulticol/positioned-with-constrained-height.html View 1 chunk +0 lines, -3 lines 0 comments Download
M LayoutTests/fast/multicol/newmulticol/regular-block-becomes-multicol.html View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/fast/multicol/newmulticol/regular-block-becomes-multicol-expected.html View 1 chunk +0 lines, -4 lines 0 comments Download
M LayoutTests/fast/multicol/newmulticol/single-line.html View 1 chunk +0 lines, -4 lines 0 comments Download
M LayoutTests/fast/multicol/newmulticol/spanner-inside-child-crash.html View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/fast/multicol/newmulticol/table-cell.html View 1 chunk +0 lines, -4 lines 0 comments Download
M LayoutTests/fast/multicol/newmulticol/unresolvable-percent-height.html View 1 chunk +0 lines, -4 lines 0 comments Download
M LayoutTests/fast/multicol/newmulticol/unresolvable-percent-height-2.html View 1 chunk +0 lines, -4 lines 0 comments Download
M LayoutTests/fast/multicol/newmulticol/unresolvable-percent-max-height.html View 1 chunk +0 lines, -4 lines 0 comments Download
M LayoutTests/fast/multicol/newmulticol/unresolvable-percent-max-height-2.html View 1 chunk +0 lines, -4 lines 0 comments Download
M LayoutTests/fast/multicol/one-column-with-break.html View 1 chunk +0 lines, -6 lines 0 comments Download
M LayoutTests/fast/multicol/percent-height.html View 1 chunk +0 lines, -4 lines 0 comments Download
M LayoutTests/fast/multicol/positioned-outside-of-columns.html View 1 chunk +0 lines, -3 lines 0 comments Download
M LayoutTests/fast/multicol/tall-float1.html View 1 chunk +0 lines, -6 lines 0 comments Download
M LayoutTests/fast/multicol/tall-float2.html View 1 chunk +0 lines, -6 lines 0 comments Download
M LayoutTests/fast/multicol/tall-float2-expected.html View 1 chunk +0 lines, -6 lines 0 comments Download
M LayoutTests/fast/multicol/transform-inside-opacity.html View 1 chunk +0 lines, -3 lines 0 comments Download
M LayoutTests/fast/multicol/widows.html View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/fast/multicol/widows2.html View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
andersr
6 years, 6 months ago (2014-06-19 16:51:31 UTC) #1
rune
lgtm
6 years, 5 months ago (2014-06-30 20:41:11 UTC) #2
rune
6 years, 5 months ago (2014-06-30 21:11:32 UTC) #3
Julien - ping for review
lgtm Ideally we should remove the Settings code and use a pure runtime flag. This ...
6 years, 5 months ago (2014-06-30 21:30:08 UTC) #4
andersr
On 2014/06/30 21:30:08, Julien Chaffraix - PST wrote: > lgtm > > Ideally we should ...
6 years, 5 months ago (2014-07-04 07:40:27 UTC) #5
andersr
The CQ bit was checked by andersr@opera.com
6 years, 5 months ago (2014-07-04 07:40:38 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/andersr@opera.com/341103002/1
6 years, 5 months ago (2014-07-04 07:41:44 UTC) #7
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_gn_rel on tryserver.blink ...
6 years, 5 months ago (2014-07-04 08:48:44 UTC) #8
commit-bot: I haz the power
6 years, 5 months ago (2014-07-04 09:25:43 UTC) #9
Message was sent while issue was closed.
Change committed as 177528

Powered by Google App Engine
This is Rietveld 408576698