LayoutTests/fast/multicol/inline-children-crash.html - Issue 341103002: [New Multicolumn] Remove unnecessary calls to setRegionBasedColumnsEnabled.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/multicol/inline-children-crash.html

Issue 341103002: [New Multicolumn] Remove unnecessary calls to setRegionBasedColumnsEnabled. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <script>	2 <script>

3 if (window.internals)

4 internals.settings.setRegionBasedColumnsEnabled(true);

5 if (window.testRunner)	3 if (window.testRunner)

6 testRunner.dumpAsText();	4 testRunner.dumpAsText();

7 onload = function() {	5 onload = function() {

8 document.getElementById('mc').offsetTop; // trigger layout	6 document.getElementById('mc').offsetTop; // trigger layout

9 document.getElementById('mc').style.webkitColumns = 'auto';	7 document.getElementById('mc').style.webkitColumns = 'auto';

10 document.getElementById('mc').style.columns = 'auto';	8 document.getElementById('mc').style.columns = 'auto';

11 document.getElementById('inline').style.color = 'green';	9 document.getElementById('inline').style.color = 'green';

12 }	10 }

13 </script>	11 </script>

14 <p>This test should not crash.</p>	12 <p>This test should not crash.</p>

15 <div id="mc" style="-webkit-columns:3; columns:3;">	13 <div id="mc" style="-webkit-columns:3; columns:3;">

16 <span id="inline">PASS</span>	14 <span id="inline">PASS</span>

17 </div>	15 </div>

OLD	NEW

« no previous file with comments | « LayoutTests/fast/multicol/cssom-view.html ('k') | LayoutTests/fast/multicol/inline-getclientrects.html » ('j') | no next file with comments »