LayoutTests/fast/multicol/inline-getclientrects.html - Issue 341103002: [New Multicolumn] Remove unnecessary calls to setRegionBasedColumnsEnabled.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/multicol/inline-getclientrects.html

Issue 341103002: [New Multicolumn] Remove unnecessary calls to setRegionBasedColumnsEnabled. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <script src="../../resources/js-test.js"></script>	2 <script src="../../resources/js-test.js"></script>

3 <script>	3 <script>

4 if (window.testRunner)	4 if (window.testRunner)

5 testRunner.dumpAsText();	5 testRunner.dumpAsText();

6 if (window.internals)

7 internals.settings.setRegionBasedColumnsEnabled(true);

8 </script>	6 </script>

9 <body style="margin-left:10px; margin-top:15px;">	7 <body style="margin-left:10px; margin-top:15px;">

10 <!-- Make a container with 9 lines. With three columns, that means three lin es per column. -->	8 <!-- Make a container with 9 lines. With three columns, that means three lin es per column. -->

11 <div style="-webkit-columns:3; columns:3; column-gap:1em; -webkit-column-gap :1em; width:32em; orphans:1; widows:1;">	9 <div style="-webkit-columns:3; columns:3; column-gap:1em; -webkit-column-gap :1em; width:32em; orphans:1; widows:1;">

12 <br>	10 <br>

13 <br>	11 <br>

14 <br>	12 <br>

15 <br>	13 <br>

16 <br>	14 <br>

17 <span id="elm">	15 <span id="elm">

18 <!-- This is at a column boundary, where the first line fits in the second column, while	16 <!-- This is at a column boundary, where the first line fits in the second column, while

19 the second line is in the third column. -->	17 the second line is in the third column. -->

20 XXXXXXXXXXXXXXXXXXXXXXXXXX	18 XXXXXXXXXXXXXXXXXXXXXXXXXX

21 XXXXXXXXXXXXXXXXXXXXXXXXXX	19 XXXXXXXXXXXXXXXXXXXXXXXXXX

22 </span><br>	20 </span><br>

23 <br>	21 <br>

24 <br>	22 <br>

25 </div>	23 </div>

26 <script>	24 <script>

27 var rects = document.getElementById('elm').getClientRects();	25 var rects = document.getElementById('elm').getClientRects();

28 shouldBe("rects.length", "2");	26 shouldBe("rects.length", "2");

29 shouldBeGreaterThan("rects[1].left", "rects[0].left");	27 shouldBeGreaterThan("rects[1].left", "rects[0].left");

30 shouldBeGreaterThan("rects[0].top", "rects[1].top");	28 shouldBeGreaterThan("rects[0].top", "rects[1].top");

31 shouldBeGreaterThan("rects[0].right - rects[0].left", "0");	29 shouldBeGreaterThan("rects[0].right - rects[0].left", "0");

32 shouldBe("rects[1].right - rects[1].left", "rects[0].right - rects[0].le ft");	30 shouldBe("rects[1].right - rects[1].left", "rects[0].right - rects[0].le ft");

33 shouldBeGreaterThan("rects[0].bottom - rects[0].top", "0");	31 shouldBeGreaterThan("rects[0].bottom - rects[0].top", "0");

34 shouldBe("rects[1].bottom - rects[1].top", "rects[0].bottom - rects[0].t op");	32 shouldBe("rects[1].bottom - rects[1].top", "rects[0].bottom - rects[0].t op");

35 </script>	33 </script>

36 </body>	34 </body>

OLD	NEW

« no previous file with comments | « LayoutTests/fast/multicol/inline-children-crash.html ('k') | LayoutTests/fast/multicol/mixed-opacity-fixed-test.html » ('j') | no next file with comments »