LayoutTests/fast/multicol/change-height.html - Issue 341103002: [New Multicolumn] Remove unnecessary calls to setRegionBasedColumnsEnabled.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/multicol/change-height.html

Issue 341103002: [New Multicolumn] Remove unnecessary calls to setRegionBasedColumnsEnabled. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « LayoutTests/fast/multicol/change-block-child-height-expected.html ('k') | LayoutTests/fast/multicol/content-change-same-height.html » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <html>	2 <html>

3 <head>	3 <head>

4 <script>	4 <script>

5 if (window.internals)

6 internals.settings.setRegionBasedColumnsEnabled(true);

7 function test() {	5 function test() {

8 var elm = document.getElementById('elm');	6 var elm = document.getElementById('elm');

9 elm.offsetTop; // trigger layout	7 elm.offsetTop; // trigger layout

10 elm.style.height = '14em';	8 elm.style.height = '14em';

11 }	9 }

12 </script>	10 </script>

13 </head>	11 </head>

14 <body onload="test()">	12 <body onload="test()">

15 <p>Below there should be <em>one</em> column with 7 lines.</p>	13 <p>Below there should be <em>one</em> column with 7 lines.</p>

16 <div id="elm" style="-webkit-columns:3; columns:3; column-fill:auto; orp hans:1; widows:1; height:4em; line-height:2em;">	14 <div id="elm" style="-webkit-columns:3; columns:3; column-fill:auto; orp hans:1; widows:1; height:4em; line-height:2em;">

17 line<br>	15 line<br>

18 line<br>	16 line<br>

19 line<br>	17 line<br>

20 line<br>	18 line<br>

21 line<br>	19 line<br>

22 line<br>	20 line<br>

23 line<br>	21 line<br>

24 </div>	22 </div>

25 </body>	23 </body>

26 </html>	24 </html>

OLD	NEW