Issue 34013002: Address codereview comments for http://crrev.com/22295002

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 34013002: Address codereview comments for http://crrev.com/22295002 (Closed)

Created:
7 years, 2 months ago by mef

Modified:
7 years ago

Reviewers:
cbentzel

CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Address codereview comments for http://crrev.com/22295002 Another portion is in https://codereview.chromium.org/30753002 BUG=267667

Patch Set 1 #

Total comments: 2

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+75 lines, -66 lines)			Patch
M	chrome/browser/extensions/api/networking_private/networking_private_api_nonchromeos.cc	View	4 chunks	+7 lines, -7 lines	0 comments	Download
M	chrome/browser/extensions/api/networking_private/networking_private_apitest.cc	View	1 chunk	+2 lines, -3 lines	0 comments	Download
M	chrome/browser/extensions/api/networking_private/networking_private_process_client.h	View	4 chunks	+15 lines, -13 lines	0 comments	Download
M	chrome/browser/extensions/api/networking_private/networking_private_process_client.cc	View	5 chunks	+13 lines, -6 lines	2 comments	Download
M	chrome/utility/networking_private_handler.h	View	4 chunks	+13 lines, -12 lines	0 comments	Download
M	chrome/utility/networking_private_handler.cc	View	9 chunks	+25 lines, -25 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

cbentzel

https://codereview.chromium.org/34013002/diff/1/chrome/browser/extensions/api/networking_private/networking_private_process_client.cc File chrome/browser/extensions/api/networking_private/networking_private_process_client.cc (right): https://codereview.chromium.org/34013002/diff/1/chrome/browser/extensions/api/networking_private/networking_private_process_client.cc#newcode369 chrome/browser/extensions/api/networking_private/networking_private_process_client.cc:369: } Nit: needs extra newline

7 years, 2 months ago (2013-10-22 00:56:26 UTC) #1

mef

7 years, 2 months ago (2013-10-22 15:03:31 UTC) #2

Message was sent while issue was closed.

Thanks!

https://codereview.chromium.org/34013002/diff/1/chrome/browser/extensions/api...
File
chrome/browser/extensions/api/networking_private/networking_private_process_client.cc
(right):

https://codereview.chromium.org/34013002/diff/1/chrome/browser/extensions/api...
chrome/browser/extensions/api/networking_private/networking_private_process_client.cc:369:
}
On 2013/10/22 00:56:26, cbentzel wrote:
> Nit: needs extra newline

Done.

Expand Messages | Collapse Messages