Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2071)

Unified Diff: chrome/browser/extensions/api/networking_private/networking_private_api_nonchromeos.cc

Issue 34013002: Address codereview comments for http://crrev.com/22295002 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/networking_private/networking_private_api_nonchromeos.cc
diff --git a/chrome/browser/extensions/api/networking_private/networking_private_api_nonchromeos.cc b/chrome/browser/extensions/api/networking_private/networking_private_api_nonchromeos.cc
index e014d3bfd94d9287c773c8c66cd4f468b55dac68..fcd8ce58fd39def89dc93a719fdce58e3c16378a 100644
--- a/chrome/browser/extensions/api/networking_private/networking_private_api_nonchromeos.cc
+++ b/chrome/browser/extensions/api/networking_private/networking_private_api_nonchromeos.cc
@@ -174,13 +174,17 @@ bool NetworkingPrivateSetPropertiesFunction::RunImpl() {
NetworkingPrivateProcessClient::GetForProfile(profile_));
process_client->SetProperties(
- params->network_guid, // service path
+ params->network_guid,
*properties_dict,
base::Bind(&NetworkingPrivateSetPropertiesFunction::ResultCallback, this),
base::Bind(&NetworkingPrivateSetPropertiesFunction::ErrorCallback, this));
return true;
}
+void NetworkingPrivateSetPropertiesFunction::ResultCallback() {
+ SendResponse(true);
+}
+
void NetworkingPrivateSetPropertiesFunction::ErrorCallback(
const std::string& error_name,
const scoped_ptr<base::DictionaryValue> error_data) {
@@ -188,10 +192,6 @@ void NetworkingPrivateSetPropertiesFunction::ErrorCallback(
SendResponse(false);
}
-void NetworkingPrivateSetPropertiesFunction::ResultCallback() {
- SendResponse(true);
-}
-
////////////////////////////////////////////////////////////////////////////////
// NetworkingPrivateCreateNetworkFunction
@@ -290,7 +290,7 @@ bool NetworkingPrivateStartConnectFunction::RunImpl() {
scoped_refptr<NetworkingPrivateProcessClient> process_client(
NetworkingPrivateProcessClient::GetForProfile(profile_));
process_client->StartConnect(
- params->network_guid, // service path
+ params->network_guid,
base::Bind(&NetworkingPrivateStartConnectFunction::ConnectionStartSuccess,
this),
base::Bind(&NetworkingPrivateStartConnectFunction::ConnectionStartFailed,
@@ -323,7 +323,7 @@ bool NetworkingPrivateStartDisconnectFunction::RunImpl() {
scoped_refptr<NetworkingPrivateProcessClient> process_client(
NetworkingPrivateProcessClient::GetForProfile(profile_));
process_client->StartDisconnect(
- params->network_guid, // service path
+ params->network_guid,
base::Bind(
&NetworkingPrivateStartDisconnectFunction::DisconnectionStartSuccess,
this),

Powered by Google App Engine
This is Rietveld 408576698