chrome/browser/extensions/api/networking_private/networking_private_apitest.cc - Issue 34013002: Address codereview comments for http://crrev.com/22295002

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/networking_private/networking_private_apitest.cc

Issue 34013002: Address codereview comments for http://crrev.com/22295002 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/networking_private/networking_private_api_nonchromeos.cc ('k') | chrome/browser/extensions/api/networking_private/networking_private_process_client.h » ('j') | chrome/browser/extensions/api/networking_private/networking_private_process_client.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/networking_private/networking_private_apitest.cc

diff --git a/chrome/browser/extensions/api/networking_private/networking_private_apitest.cc b/chrome/browser/extensions/api/networking_private/networking_private_apitest.cc

index 1a1f180889a6d23617fff61f30f5e7dbeb258f2d..57481d2bb2c9c664fb9f5e8dbd0215e0ac27f10a 100644

--- a/chrome/browser/extensions/api/networking_private/networking_private_apitest.cc

+++ b/chrome/browser/extensions/api/networking_private/networking_private_apitest.cc

@@ -257,12 +257,11 @@ class ExtensionNetworkingPrivateApiTest :

process_client_ =

extensions::NetworkingPrivateProcessClient::GetForProfile(profile());

// Use Mocks WiFiService to test plumbing.

- process_client_->SetupForTest(mock_parameters, new CryptoVerifyMock());

+ process_client_->SetUpForTest(mock_parameters, new CryptoVerifyMock());

}

virtual void TearDownOnMainThread() OVERRIDE {

- base::DictionaryValue mock_parameters;

- process_client_->SetupForTest(mock_parameters, NULL);

+ process_client_->TearDownForTest();

}

scoped_refptr<extensions::NetworkingPrivateProcessClient> process_client_;