Issue 30753002: Move GetVisibleNetworks network type filtering to WiFiService interface.

Issue 30753002: Move GetVisibleNetworks network type filtering to WiFiService interface. (Closed)

Created:
7 years, 2 months ago by mef

Modified:
7 years ago

Reviewers:
cbentzel, tbarzic

CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Move GetVisibleNetworks network type filtering to WiFiService interface. Based on infrastructure in http://crrev.com/22295002 BUG=267667

Patch Set 2 : Sync to r230127 #

Patch Set 3 : Address codereview comments. #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+49 lines, -50 lines)			Patch
M	chrome/browser/extensions/api/networking_private/networking_private_api_nonchromeos.cc	View	1	1 chunk	+5 lines, -29 lines	0 comments	Download
M	chrome/browser/extensions/api/networking_private/networking_private_process_client.h	View	1	2 chunks	+11 lines, -10 lines	0 comments	Download
M	chrome/browser/extensions/api/networking_private/networking_private_process_client.cc	View	1	1 chunk	+4 lines, -1 line	0 comments	Download
M	chrome/common/networking_private_messages.h	View	1 2	1 chunk	+4 lines, -3 lines	0 comments	Download
M	chrome/utility/networking_private_handler.h	View	1	1 chunk	+4 lines, -2 lines	0 comments	Download
M	chrome/utility/networking_private_handler.cc	View	1	2 chunks	+5 lines, -1 line	0 comments	Download
M	chrome/utility/wifi/wifi_service.h	View		1 chunk	+4 lines, -3 lines	0 comments	Download
M	chrome/utility/wifi/wifi_service_mock.cc	View	1 2	1 chunk	+12 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

mef

Hi guys, please take a look. This is a separate CL to move filtering of ...

7 years, 2 months ago (2013-10-19 21:17:59 UTC) #1

tbarzic

lgtm with two nits https://codereview.chromium.org/30753002/diff/1/chrome/common/networking_private_messages.h File chrome/common/networking_private_messages.h (right): https://codereview.chromium.org/30753002/diff/1/chrome/common/networking_private_messages.h#newcode51 chrome/common/networking_private_messages.h:51: ) nit: ) to the ...

7 years, 2 months ago (2013-10-23 00:30:23 UTC) #2

mef

7 years, 2 months ago (2013-10-23 13:00:24 UTC) #3

Thanks, Toni!

Per discussion with Chris I'm not planning to merge this into
https://codereview.chromium.org/22295002/, but rather land it separately
afterwards. 

Let me know if you have any concerns.

https://codereview.chromium.org/30753002/diff/1/chrome/common/networking_priv...
File chrome/common/networking_private_messages.h (right):

https://codereview.chromium.org/30753002/diff/1/chrome/common/networking_priv...
chrome/common/networking_private_messages.h:51: )
On 2013/10/23 00:30:24, tbarzic wrote:
> nit: ) to the line before

Done.

https://codereview.chromium.org/30753002/diff/1/chrome/utility/wifi/wifi_serv...
File chrome/utility/wifi/wifi_service_mock.cc (right):

https://codereview.chromium.org/30753002/diff/1/chrome/utility/wifi/wifi_serv...
chrome/utility/wifi/wifi_service_mock.cc:124: ++it) {
On 2013/10/23 00:30:24, tbarzic wrote:
> align ++it with NetworkList 

Done.

Expand Messages | Collapse Messages