Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(329)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 339193005: Mojo: Rename (Mojo)WaitFlagsState -> (Mojo)HandleSignalsState. (Closed)

Created:
6 years, 6 months ago by viettrungluu
Modified:
6 years, 6 months ago
Reviewers:
sky
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Project:
chromium
Visibility:
Public.

Description

Mojo: Rename (Mojo)WaitFlagsState -> (Mojo)HandleSignalsState. (And wait_flags_state.h -> handle_signals_state.h.) Still to do: Java (WaitFlags -> HandleSignals). R=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278094

Patch Set 1 #

Patch Set 2 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+114 lines, -152 lines) Patch
M mojo/mojo.gyp View 2 chunks +1 line, -1 line 0 comments Download
M mojo/public/c/system/types.h View 1 chunk +3 lines, -4 lines 0 comments Download
M mojo/public/js/bindings/support.js View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/system/BUILD.gn View 2 chunks +1 line, -1 line 0 comments Download
M mojo/system/data_pipe.h View 4 chunks +5 lines, -5 lines 0 comments Download
M mojo/system/data_pipe.cc View 13 chunks +20 lines, -18 lines 0 comments Download
A + mojo/system/handle_signals_state.h View 3 chunks +13 lines, -11 lines 0 comments Download
M mojo/system/local_data_pipe.h View 2 chunks +4 lines, -2 lines 0 comments Download
M mojo/system/local_data_pipe.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M mojo/system/local_message_pipe_endpoint.h View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/system/local_message_pipe_endpoint.cc View 5 chunks +7 lines, -7 lines 0 comments Download
M mojo/system/platform_handle_dispatcher.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/system/platform_handle_dispatcher.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M mojo/system/shared_buffer_dispatcher.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/system/shared_buffer_dispatcher.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/system/simple_dispatcher.h View 2 chunks +5 lines, -5 lines 0 comments Download
M mojo/system/simple_dispatcher.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M mojo/system/simple_dispatcher_unittest.cc View 3 chunks +4 lines, -4 lines 0 comments Download
D mojo/system/wait_flags_state.h View 1 chunk +0 lines, -48 lines 0 comments Download
M mojo/system/waiter_list.h View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/system/waiter_list.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/system/waiter_list_unittest.cc View 12 chunks +29 lines, -25 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
viettrungluu
(Dependent on https://codereview.chromium.org/339193005/, hence on https://codereview.chromium.org/345463003/.)
6 years, 6 months ago (2014-06-18 00:31:31 UTC) #1
sky
LGTM (I tire of these)
6 years, 6 months ago (2014-06-18 03:31:56 UTC) #2
viettrungluu
6 years, 6 months ago (2014-06-18 15:51:22 UTC) #3
Message was sent while issue was closed. 
Committed patchset #2 manually as r278094 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698