Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(593)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 345463003: Mojo: MojoWaitFlags -> MojoHandleSignals. (Closed)

Created:
6 years, 6 months ago by viettrungluu
Modified:
6 years, 6 months ago
Reviewers:
sky
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Project:
chromium
Visibility:
Public.

Description

Mojo: MojoWaitFlags -> MojoHandleSignals. I still have to rename MOJO_WAIT_... and MojoWaitFlagsState, but I'll do that separately. R=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278012

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+298 lines, -285 lines) Patch
M mojo/android/system/core_impl.cc View 4 chunks +7 lines, -7 lines 0 comments Download
M mojo/bindings/js/core.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M mojo/bindings/js/support.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M mojo/bindings/js/waiting_callback.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/bindings/js/waiting_callback.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/common/handle_watcher.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/common/handle_watcher.cc View 7 chunks +11 lines, -11 lines 0 comments Download
M mojo/common/message_pump_mojo.h View 2 chunks +3 lines, -3 lines 0 comments Download
M mojo/common/message_pump_mojo.cc View 6 chunks +7 lines, -7 lines 0 comments Download
M mojo/environment/default_async_waiter_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/public/c/environment/async_waiter.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/c/system/functions.h View 1 chunk +13 lines, -13 lines 0 comments Download
M mojo/public/c/system/tests/core_unittest.cc View 6 chunks +9 lines, -9 lines 0 comments Download
M mojo/public/c/system/tests/core_unittest_pure_c.c View 2 chunks +3 lines, -3 lines 0 comments Download
M mojo/public/c/system/types.h View 1 chunk +16 lines, -13 lines 0 comments Download
M mojo/public/cpp/environment/lib/default_async_waiter.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/public/cpp/environment/tests/async_waiter_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/public/cpp/system/core.h View 2 chunks +11 lines, -10 lines 0 comments Download
M mojo/public/cpp/system/tests/core_unittest.cc View 2 chunks +7 lines, -7 lines 0 comments Download
M mojo/public/cpp/utility/lib/run_loop.cc View 6 chunks +8 lines, -7 lines 0 comments Download
M mojo/public/cpp/utility/run_loop.h View 2 chunks +3 lines, -3 lines 0 comments Download
M mojo/public/js/bindings/core.js View 3 chunks +8 lines, -7 lines 0 comments Download
M mojo/public/js/bindings/support.js View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/platform/native/system_thunks.h View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/public/platform/native/system_thunks.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M mojo/spy/spy.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M mojo/system/core.h View 2 chunks +3 lines, -3 lines 0 comments Download
M mojo/system/core.cc View 3 chunks +7 lines, -7 lines 0 comments Download
M mojo/system/core_test_base.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/system/core_unittest.cc View 6 chunks +23 lines, -22 lines 0 comments Download
M mojo/system/data_pipe.h View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/system/data_pipe.cc View 2 chunks +8 lines, -8 lines 0 comments Download
M mojo/system/data_pipe_consumer_dispatcher.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/system/data_pipe_consumer_dispatcher.cc View 1 chunk +5 lines, -4 lines 0 comments Download
M mojo/system/data_pipe_producer_dispatcher.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/system/data_pipe_producer_dispatcher.cc View 1 chunk +5 lines, -4 lines 0 comments Download
M mojo/system/dispatcher.h View 2 chunks +8 lines, -6 lines 0 comments Download
M mojo/system/dispatcher.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M mojo/system/entrypoints.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M mojo/system/local_data_pipe.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M mojo/system/local_message_pipe_endpoint.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/system/local_message_pipe_endpoint.cc View 2 chunks +8 lines, -8 lines 0 comments Download
M mojo/system/message_pipe.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/system/message_pipe.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/system/message_pipe_dispatcher.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/system/message_pipe_dispatcher.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/system/message_pipe_endpoint.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/system/message_pipe_endpoint.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/system/multiprocess_message_pipe_unittest.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M mojo/system/simple_dispatcher.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/system/simple_dispatcher.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M mojo/system/simple_dispatcher_unittest.cc View 17 chunks +38 lines, -38 lines 0 comments Download
M mojo/system/wait_flags_state.h View 1 chunk +11 lines, -11 lines 0 comments Download
M mojo/system/waiter_list.h View 1 chunk +4 lines, -4 lines 0 comments Download
M mojo/system/waiter_list.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M mojo/system/waiter_test_utils.h View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/system/waiter_test_utils.cc View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
viettrungluu
6 years, 6 months ago (2014-06-17 23:04:30 UTC) #1
sky
LGTM
6 years, 6 months ago (2014-06-18 00:08:20 UTC) #2
viettrungluu
The CQ bit was checked by viettrungluu@chromium.org
6 years, 6 months ago (2014-06-18 00:13:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/viettrungluu@chromium.org/345463003/1
6 years, 6 months ago (2014-06-18 00:13:59 UTC) #4
commit-bot: I haz the power
6 years, 6 months ago (2014-06-18 10:18:15 UTC) #5
Message was sent while issue was closed. 
Change committed as 278012

Powered by Google App Engine
This is Rietveld 408576698