Issue 338633011: Deprecate SkPicture::clone().

Issue 338633011: Deprecate SkPicture::clone(). (Closed)

Created:
6 years, 5 months ago by mtklein_C

Modified:
6 years, 5 months ago

Reviewers:
mtklein, bsalomon, robertphillips

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

More Reviews

Description

Deprecate SkPicture::clone(). Chrome will need -DSK_SUPPORT_LEGACY_PICTURE_CLONE. This removes the modes from our tools that use clone(). No bots run these. DM used clone() in a way that we can just share the picture now. I plan to bring back the ability to test multithreaded picture rendering soon. BUG=skia:2378 Committed: https://skia.googlesource.com/skia/+/d3e474e20c6f0f24ddb6b2643e92975d60190daa

Patch Set 1 #

Patch Set 2 : SkCountdown is dead code #

Patch Set 3 : add define for chrome #

Total comments: 2

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+43 lines, -403 lines)			Patch
M	dm/DM.cpp	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	dm/DMPDFTask.h	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	dm/DMPDFTask.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	gyp/skia_for_chromium_defines.gypi	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
M	gyp/utils.gypi	View	1	1 chunk	+0 lines, -2 lines	0 comments	Download
M	include/core/SkPicture.h	View		2 chunks	+2 lines, -0 lines	0 comments	Download
D	include/utils/SkCountdown.h	View	1	1 chunk	+0 lines, -36 lines	0 comments	Download
M	src/core/SkPicture.cpp	View		2 chunks	+2 lines, -0 lines	0 comments	Download
M	src/core/SkPicturePlayback.h	View		2 chunks	+6 lines, -0 lines	0 comments	Download
M	src/core/SkPicturePlayback.cpp	View		2 chunks	+27 lines, -0 lines	2 comments	Download
D	src/utils/SkCountdown.cpp	View	1	1 chunk	+0 lines, -32 lines	0 comments	Download
M	tests/PictureTest.cpp	View		3 chunks	+0 lines, -23 lines	0 comments	Download
M	tools/PictureRenderer.h	View		5 chunks	+0 lines, -38 lines	0 comments	Download
M	tools/PictureRenderer.cpp	View		2 chunks	+0 lines, -205 lines	0 comments	Download
M	tools/PictureRenderingFlags.cpp	View		6 chunks	+0 lines, -45 lines	0 comments	Download
M	tools/bench_pictures_main.cpp	View		2 chunks	+0 lines, -5 lines	0 comments	Download
M	tools/render_pictures_main.cpp	View		3 chunks	+0 lines, -12 lines	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

robertphillips

lgtm + 1 question https://codereview.chromium.org/338633011/diff/40001/src/core/SkPicturePlayback.cpp File src/core/SkPicturePlayback.cpp (right): https://codereview.chromium.org/338633011/diff/40001/src/core/SkPicturePlayback.cpp#newcode227 src/core/SkPicturePlayback.cpp:227: #else Do we even need ...

6 years, 5 months ago (2014-06-27 18:03:50 UTC) #2

mtklein

https://codereview.chromium.org/338633011/diff/40001/src/core/SkPicturePlayback.cpp File src/core/SkPicturePlayback.cpp (right): https://codereview.chromium.org/338633011/diff/40001/src/core/SkPicturePlayback.cpp#newcode227 src/core/SkPicturePlayback.cpp:227: #else On 2014/06/27 18:03:50, robertphillips wrote: > Do we ...

6 years, 5 months ago (2014-06-27 18:32:04 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/338633011/40001

6 years, 5 months ago (2014-06-27 18:45:17 UTC) #7

commit-bot: I haz the power

6 years, 5 months ago (2014-06-27 19:34:49 UTC) #8

Message was sent while issue was closed.

Change committed as d3e474e20c6f0f24ddb6b2643e92975d60190daa

Expand Messages | Collapse Messages