Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Keyboard Shortcuts
File
u
:
up to issue
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
Issue
u
:
up to list of issues
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr)
|
Please choose your nickname with
Settings
|
Help
|
Chromium Project
|
Gerrit Changes
|
Sign out
(624)
Issues
Search
My Issues
|
Starred
Open
|
Closed
|
All
Side by Side Diff: src/utils/SkCountdown.cpp
Issue
338633011
:
Deprecate SkPicture::clone(). (Closed)
Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: add define for chrome
Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Context:
3 lines
10 lines
25 lines
50 lines
75 lines
100 lines
Whole file
Column Width:
Tab Spaces:
Jump to:
dm/DM.cpp
dm/DMPDFTask.h
dm/DMPDFTask.cpp
gyp/skia_for_chromium_defines.gypi
gyp/utils.gypi
include/core/SkPicture.h
include/utils/SkCountdown.h
src/core/SkPicture.cpp
src/core/SkPicturePlayback.h
src/core/SkPicturePlayback.cpp
src/utils/SkCountdown.cpp
tests/PictureTest.cpp
tools/PictureRenderer.h
tools/PictureRenderer.cpp
tools/PictureRenderingFlags.cpp
tools/bench_pictures_main.cpp
tools/render_pictures_main.cpp
View unified diff
|
Download patch
« src/core/SkPicturePlayback.cpp
('K') |
« src/core/SkPicturePlayback.cpp
('k') |
tests/PictureTest.cpp »
('j') |
no next file with comments »
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
(Empty)
1
/*
2
* Copyright 2012 Google Inc.
3
*
4
* Use of this source code is governed by a BSD-style license that can be
5
* found in the LICENSE file.
6
*/
7
8
#include "SkCountdown.h"
9
#include "SkThread.h"
10
11
SkCountdown::SkCountdown(int32_t count)
12
: fCount(count) {}
13
14
void SkCountdown::reset(int32_t count) {
15
fCount = count;
16
}
17
18
void SkCountdown::run() {
19
if (sk_atomic_dec(&fCount) == 1) {
20
fReady.lock();
21
fReady.signal();
22
fReady.unlock();
23
}
24
}
25
26
void SkCountdown::wait() {
27
fReady.lock();
28
while (fCount > 0) {
29
fReady.wait();
30
}
31
fReady.unlock();
32
}
OLD
NEW
« src/core/SkPicturePlayback.cpp
('K') |
« src/core/SkPicturePlayback.cpp
('k') |
tests/PictureTest.cpp »
('j') |
no next file with comments »
Issue 338633011: Deprecate SkPicture::clone(). (Closed)
Created 6 years, 5 months ago by mtklein_C
Modified 6 years, 5 months ago
Reviewers: robertphillips, mtklein, bsalomon
Base URL: https://skia.googlesource.com/skia.git@master
Comments: 2
This is Rietveld
408576698
Chromium Code Reviews
Issue 338633011:
Deprecate SkPicture::clone(). (Closed)
Base URL: https://skia.googlesource.com/skia.git@master