src/core/SkPicture.cpp - Issue 338633011: Deprecate SkPicture::clone().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/core/SkPicture.cpp

Issue 338633011: Deprecate SkPicture::clone(). (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: add define for chrome Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/core/SkPicture.cpp

diff --git a/src/core/SkPicture.cpp b/src/core/SkPicture.cpp

index 75160b8be4bf6afd93ceda34378b5013dca17186..45a0d2c38c36100f270e863d41d09351cdd13548 100644

--- a/src/core/SkPicture.cpp

+++ b/src/core/SkPicture.cpp

@@ -185,6 +185,7 @@ SkPicture::SkPicture(const SkPicture& src) : INHERITED() {

// fRecord OK

SkPicture::~SkPicture() {}

+#ifdef SK_SUPPORT_LEGACY_PICTURE_CLONE

// fRecord TODO, fix by deleting this method

SkPicture* SkPicture::clone() const {

SkPicture* clonedPicture = SkNEW(SkPicture);

@@ -256,6 +257,7 @@ void SkPicture::clone(SkPicture* pictures, int count) const {

}

+#endif//SK_SUPPORT_LEGACY_PICTURE_CLONE

// fRecord OK

void SkPicture::EXPERIMENTAL_addAccelData(const SkPicture::AccelData* data) const {