Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Unified Diff: tools/render_pictures_main.cpp

Issue 338633011: Deprecate SkPicture::clone(). (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: add define for chrome Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« src/core/SkPicturePlayback.cpp ('K') | « tools/bench_pictures_main.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/render_pictures_main.cpp
diff --git a/tools/render_pictures_main.cpp b/tools/render_pictures_main.cpp
index 850053cfc6f9b258469ac8ab3077f81cd378b2f8..c2c7875b282cc6cfbd8a0aa6b8a38eba0eecb678 100644
--- a/tools/render_pictures_main.cpp
+++ b/tools/render_pictures_main.cpp
@@ -26,7 +26,6 @@
#include "picture_utils.h"
// Flags used by this file, alphabetically:
-DEFINE_int32(clone, 0, "Clone the picture n times before rendering.");
DECLARE_bool(deferImageDecoding);
DEFINE_int32(maxComponentDiff, 256, "Maximum diff on a component, 0 - 256. Components that differ "
"by more than this amount are considered errors, though all diffs are reported. "
@@ -186,12 +185,6 @@ static bool render_picture_internal(const SkString& inputPath, const SkString* w
SkAutoTUnref<SkPicture> other(recorder.endRecording());
}
- for (int i = 0; i < FLAGS_clone; ++i) {
- SkPicture* clone = picture->clone();
- SkDELETE(picture);
- picture = clone;
- }
-
SkDebugf("drawing... [%i %i] %s\n", picture->width(), picture->height(),
inputPath.c_str());
@@ -424,11 +417,6 @@ int tool_main(int argc, char** argv) {
exit(-1);
}
- if (FLAGS_clone < 0) {
- SkDebugf("--clone must be >= 0. Was %i\n", FLAGS_clone);
- exit(-1);
- }
-
if (FLAGS_writeEncodedImages) {
if (FLAGS_writePath.isEmpty()) {
SkDebugf("--writeEncodedImages requires --writePath\n");
« src/core/SkPicturePlayback.cpp ('K') | « tools/bench_pictures_main.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698