Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(617)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 337603005: Rename telemetry.test.Test to telemetry.benchmark.Benchmark. (Closed)

Created:
6 years, 6 months ago by nednguyen
Modified:
6 years, 5 months ago
CC:
chromium-reviews, piman+watch_chromium.org, telemetry+watch_chromium.org, jam, darin-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Rename telemetry.test.Test to telemetry.benchmark.Benchmark. BUG=383629 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=280332

Patch Set 1 #

Total comments: 3

Patch Set 2 : Rebase. Address Dave's comment #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+308 lines, -511 lines) Patch
M content/test/gpu/gpu_tests/cloud_storage_test_base.py View 2 chunks +2 lines, -2 lines 0 comments Download
M content/test/gpu/gpu_tests/context_lost.py View 2 chunks +2 lines, -2 lines 0 comments Download
M content/test/gpu/gpu_tests/gpu_process.py View 2 chunks +2 lines, -2 lines 0 comments Download
M content/test/gpu/gpu_tests/hardware_accelerated_feature.py View 2 chunks +2 lines, -2 lines 0 comments Download
M content/test/gpu/gpu_tests/maps.py View 1 1 chunk +1 line, -1 line 0 comments Download
M content/test/gpu/gpu_tests/memory.py View 1 2 chunks +2 lines, -2 lines 0 comments Download
M content/test/gpu/gpu_tests/pixel.py View 1 chunk +1 line, -1 line 0 comments Download
M content/test/gpu/gpu_tests/screenshot_sync.py View 1 2 4 chunks +5 lines, -5 lines 0 comments Download
M content/test/gpu/gpu_tests/webgl_conformance.py View 1 2 chunks +2 lines, -2 lines 0 comments Download
M content/test/gpu/gpu_tests/webgl_robustness.py View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/perf/benchmarks/benchmark_unittest.py View 1 4 chunks +8 lines, -8 lines 0 comments Download
M tools/perf/benchmarks/blink_perf.py View 3 chunks +3 lines, -3 lines 0 comments Download
M tools/perf/benchmarks/browsermark.py View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/perf/benchmarks/canvasmark.py View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/perf/benchmarks/chrome_proxy.py View 5 chunks +11 lines, -11 lines 0 comments Download
M tools/perf/benchmarks/dom_perf.py View 2 chunks +3 lines, -3 lines 0 comments Download
M tools/perf/benchmarks/dromaeo.py View 1 3 chunks +3 lines, -3 lines 0 comments Download
M tools/perf/benchmarks/endure.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/perf/benchmarks/html5gaming.py View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/perf/benchmarks/image_decoding.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/perf/benchmarks/indexeddb_perf.py View 1 2 chunks +2 lines, -2 lines 0 comments Download
M tools/perf/benchmarks/jetstream.py View 2 chunks +3 lines, -3 lines 0 comments Download
M tools/perf/benchmarks/jsgamebench.py View 2 chunks +3 lines, -3 lines 0 comments Download
M tools/perf/benchmarks/kraken.py View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/perf/benchmarks/maps.py View 2 chunks +3 lines, -3 lines 0 comments Download
M tools/perf/benchmarks/media.py View 5 chunks +7 lines, -7 lines 0 comments Download
M tools/perf/benchmarks/memory.py View 1 chunk +7 lines, -7 lines 0 comments Download
M tools/perf/benchmarks/memory_pressure.py View 1 1 chunk +3 lines, -3 lines 0 comments Download
M tools/perf/benchmarks/octane.py View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/perf/benchmarks/page_cycler.py View 1 3 chunks +20 lines, -20 lines 0 comments Download
M tools/perf/benchmarks/peacekeeper.py View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/perf/benchmarks/pica.py View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/perf/benchmarks/polymer_load.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/perf/benchmarks/rasterize_and_record_micro.py View 5 chunks +12 lines, -11 lines 0 comments Download
M tools/perf/benchmarks/repaint.py View 2 chunks +3 lines, -3 lines 0 comments Download
M tools/perf/benchmarks/robohornet_pro.py View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/perf/benchmarks/scheduler.py View 1 2 chunks +4 lines, -4 lines 0 comments Download
M tools/perf/benchmarks/scirra.py View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/perf/benchmarks/service_worker.py View 1 2 chunks +2 lines, -2 lines 0 comments Download
M tools/perf/benchmarks/session_restore.py View 5 chunks +6 lines, -6 lines 0 comments Download
M tools/perf/benchmarks/smoothness.py View 1 11 chunks +26 lines, -26 lines 0 comments Download
M tools/perf/benchmarks/spaceport.py View 2 chunks +3 lines, -3 lines 0 comments Download
M tools/perf/benchmarks/speedometer.py View 2 chunks +3 lines, -3 lines 0 comments Download
M tools/perf/benchmarks/start_with_url.py View 2 chunks +4 lines, -4 lines 0 comments Download
M tools/perf/benchmarks/startup.py View 5 chunks +10 lines, -10 lines 0 comments Download
M tools/perf/benchmarks/sunspider.py View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/perf/benchmarks/tab_switching.py View 1 1 chunk +9 lines, -9 lines 0 comments Download
M tools/perf/benchmarks/thread_times.py View 5 chunks +7 lines, -7 lines 0 comments Download
M tools/perf/benchmarks/webrtc.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/perf/measurements/rasterize_and_record_micro_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/measurements/record_per_area_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/measurements/repaint_unittest.py View 1 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/measurements/screenshot_unittest.py View 1 2 chunks +2 lines, -2 lines 0 comments Download
M tools/perf/measurements/skpicture_printer_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/measurements/thread_times_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
A + tools/telemetry/telemetry/benchmark.py View 1 3 chunks +6 lines, -6 lines 0 comments Download
M tools/telemetry/telemetry/core/backends/chrome/android_browser_finder_unittest.py View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/core/backends/chrome/cros_interface_unittest.py View 11 chunks +13 lines, -13 lines 0 comments Download
M tools/telemetry/telemetry/core/backends/chrome/cros_unittest.py View 5 chunks +6 lines, -6 lines 0 comments Download
M tools/telemetry/telemetry/core/backends/chrome/inspector_memory_unittest.py View 1 1 chunk +2 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/core/backends/form_based_credentials_backend_unittest_base.py View 3 chunks +3 lines, -3 lines 0 comments Download
M tools/telemetry/telemetry/core/bitmap_unittest.py View 8 chunks +8 lines, -8 lines 0 comments Download
M tools/telemetry/telemetry/core/browser_unittest.py View 1 4 chunks +5 lines, -5 lines 0 comments Download
M tools/telemetry/telemetry/core/platform/android_platform_backend_unittest.py View 3 chunks +3 lines, -3 lines 0 comments Download
M tools/telemetry/telemetry/core/platform/mac_platform_backend_unittest.py View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/core/platform/posix_platform_backend_unittest.py View 1 2 chunks +2 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/core/platform/power_monitor/powermetrics_power_monitor_unittest.py View 3 chunks +4 lines, -4 lines 0 comments Download
M tools/telemetry/telemetry/core/platform/profiler/android_profiling_helper_unittest.py View 4 chunks +4 lines, -4 lines 0 comments Download
M tools/telemetry/telemetry/core/platform/profiler/android_systrace_profiler_unittest.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/core/tab_unittest.py View 1 3 chunks +3 lines, -3 lines 0 comments Download
M tools/telemetry/telemetry/core/video_unittest.py View 1 2 chunks +2 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/page/actions/action_runner_unittest.py View 1 2 chunks +2 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/page/page_measurement_unittest.py View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/page/record_wpr.py View 1 2 chunks +2 lines, -2 lines 0 comments Download
D tools/telemetry/telemetry/test.py View 1 1 chunk +0 lines, -205 lines 0 comments Download
M tools/telemetry/telemetry/test_runner.py View 1 7 chunks +9 lines, -8 lines 0 comments Download
M tools/telemetry/telemetry/util/find_dependencies.py View 1 2 chunks +2 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/web_perf/timeline_based_measurement_unittest.py View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
nednguyen
6 years, 6 months ago (2014-06-19 21:09:01 UTC) #1
nednguyen
I basically did a bunch of 'sed' commands. There may be mistake somewhere...
6 years, 6 months ago (2014-06-19 21:09:39 UTC) #2
nednguyen
6 years, 6 months ago (2014-06-19 21:12:05 UTC) #3
Ken Russell (switch to Gerrit)
The tests in under content/test/gpu/ definitely aren't benchmarks, though I agree this renaming is better ...
6 years, 6 months ago (2014-06-20 18:54:09 UTC) #4
nednguyen
On 2014/06/20 18:54:09, Ken Russell wrote: > The tests in under content/test/gpu/ definitely aren't benchmarks, ...
6 years, 6 months ago (2014-06-20 20:50:50 UTC) #5
nduca
lgtm when you'r ready this is great
6 years, 6 months ago (2014-06-25 02:35:19 UTC) #6
dtu
lgtm % nits https://codereview.chromium.org/337603005/diff/1/tools/perf/benchmarks/benchmark_unittest.py File tools/perf/benchmarks/benchmark_unittest.py (right): https://codereview.chromium.org/337603005/diff/1/tools/perf/benchmarks/benchmark_unittest.py#newcode22 tools/perf/benchmarks/benchmark_unittest.py:22: # In general you should @benchmark.Disabled ...
6 years, 6 months ago (2014-06-25 23:59:39 UTC) #7
nednguyen
The CQ bit was checked by nednguyen@google.com
6 years, 5 months ago (2014-06-27 09:43:04 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nednguyen@google.com/337603005/20001
6 years, 5 months ago (2014-06-27 09:44:08 UTC) #9
nednguyen
The CQ bit was checked by nednguyen@google.com
6 years, 5 months ago (2014-06-27 13:00:09 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nednguyen@google.com/337603005/40001
6 years, 5 months ago (2014-06-27 13:00:43 UTC) #11
commit-bot: I haz the power
6 years, 5 months ago (2014-06-27 15:01:38 UTC) #12
Message was sent while issue was closed. 
Change committed as 280332

Powered by Google App Engine
This is Rietveld 408576698