tools/telemetry/telemetry/core/backends/form_based_credentials_backend_unittest_base.py - Issue 337603005: Rename telemetry.test.Test to telemetry.benchmark.Benchmark.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/core/backends/form_based_credentials_backend_unittest_base.py

Issue 337603005: Rename telemetry.test.Test to telemetry.benchmark.Benchmark. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/telemetry/telemetry/core/backends/chrome/inspector_memory_unittest.py ('k') | tools/telemetry/telemetry/core/bitmap_unittest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/core/backends/form_based_credentials_backend_unittest_base.py

diff --git a/tools/telemetry/telemetry/core/backends/form_based_credentials_backend_unittest_base.py b/tools/telemetry/telemetry/core/backends/form_based_credentials_backend_unittest_base.py

index 483ce2b340768c8d65e4bcdd7a3578db9eb899e7..3ce0c864aa0cb371ff22b8cdf9839dc948daeeae 100644

--- a/tools/telemetry/telemetry/core/backends/form_based_credentials_backend_unittest_base.py

+++ b/tools/telemetry/telemetry/core/backends/form_based_credentials_backend_unittest_base.py

@@ -6,7 +6,7 @@ import logging

import os

import unittest

-from telemetry import test

+from telemetry import benchmark

from telemetry.core import browser_finder

from telemetry.core import util

from telemetry.unittest import options_for_unittests

@@ -28,7 +28,7 @@ class FormBasedCredentialsBackendUnitTestBase(unittest.TestCase):

def setUp(self):

self._credentials_type = None

- @test.Disabled

+ @benchmark.Disabled

def testRealLoginIfPossible(self):

credentials_path = _GetCredentialsPath()

if not credentials_path:

@@ -43,7 +43,7 @@ class FormBasedCredentialsBackendUnitTestBase(unittest.TestCase):

ret = b.credentials.LoginNeeded(b.tabs[0], self._credentials_type)

self.assertTrue(ret)

- @test.Disabled

+ @benchmark.Disabled

def testRealLoginWithDontOverrideProfileIfPossible(self):

credentials_path = _GetCredentialsPath()

if not credentials_path: