tools/telemetry/telemetry/core/tab_unittest.py - Issue 337603005: Rename telemetry.test.Test to telemetry.benchmark.Benchmark.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/core/tab_unittest.py

Issue 337603005: Rename telemetry.test.Test to telemetry.benchmark.Benchmark. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/telemetry/telemetry/core/platform/profiler/android_systrace_profiler_unittest.py ('k') | tools/telemetry/telemetry/core/video_unittest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/core/tab_unittest.py

diff --git a/tools/telemetry/telemetry/core/tab_unittest.py b/tools/telemetry/telemetry/core/tab_unittest.py

index 5b179caf981e3fe9238c1f5b22ebdc207af30b4d..53db4339302bfd008a9da5cc878a688b05014c53 100644

--- a/tools/telemetry/telemetry/core/tab_unittest.py

+++ b/tools/telemetry/telemetry/core/tab_unittest.py

@@ -4,7 +4,7 @@

import logging

-from telemetry import test

+from telemetry import benchmark

from telemetry.core import bitmap

from telemetry.core import video

from telemetry.core import util

@@ -57,7 +57,7 @@ class TabTest(tab_test_case.TabTestCase):

lambda: self._tab.Navigate('chrome://crash',

timeout=5))

- @test.Enabled('has tabs')

+ @benchmark.Enabled('has tabs')

def testActivateTab(self):

util.WaitFor(lambda: _IsDocumentVisible(self._tab), timeout=5)

new_tab = self._browser.tabs.New()

@@ -155,7 +155,7 @@ class GpuTabTest(tab_test_case.TabTestCase):

super(GpuTabTest, self).setUp()

# Test flaky on mac: http://crbug.com/358664

- @test.Disabled('android', 'mac')

+ @benchmark.Disabled('android', 'mac')

def testScreenshot(self):

if not self._tab.screenshot_supported:

logging.warning('Browser does not support screenshots, skipping test.')