tools/telemetry/telemetry/core/platform/profiler/android_profiling_helper_unittest.py - Issue 337603005: Rename telemetry.test.Test to telemetry.benchmark.Benchmark.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/core/platform/profiler/android_profiling_helper_unittest.py

Issue 337603005: Rename telemetry.test.Test to telemetry.benchmark.Benchmark. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/telemetry/telemetry/core/platform/power_monitor/powermetrics_power_monitor_unittest.py ('k') | tools/telemetry/telemetry/core/platform/profiler/android_systrace_profiler_unittest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/core/platform/profiler/android_profiling_helper_unittest.py

diff --git a/tools/telemetry/telemetry/core/platform/profiler/android_profiling_helper_unittest.py b/tools/telemetry/telemetry/core/platform/profiler/android_profiling_helper_unittest.py

index 5a23dbb92a84892d6c9a0f15527b7347d94991d7..1b839fd1ed22bc511df3879dac324ce65bac1676 100644

--- a/tools/telemetry/telemetry/core/platform/profiler/android_profiling_helper_unittest.py

+++ b/tools/telemetry/telemetry/core/platform/profiler/android_profiling_helper_unittest.py

@@ -8,7 +8,7 @@ import re

import shutil

import tempfile

-from telemetry import test

+from telemetry import benchmark

from telemetry.core import util

from telemetry.core.platform.profiler import android_profiling_helper

from telemetry.unittest import simple_mock

@@ -63,7 +63,7 @@ class TestAndroidProfilingHelper(tab_test_case.TabTestCase):

finally:

android_profiling_helper.subprocess = real_subprocess

- @test.Enabled('android')

+ @benchmark.Enabled('android')

def testGetRequiredLibrariesForVTuneProfile(self):

vtune_db_output = os.path.join(

util.GetUnittestDataDir(), 'sample_vtune_db_output')

@@ -94,7 +94,7 @@ class TestAndroidProfilingHelper(tab_test_case.TabTestCase):

finally:

android_profiling_helper.sqlite3 = real_sqlite3

- @test.Enabled('android')

+ @benchmark.Enabled('android')

def testCreateSymFs(self):

# pylint: disable=W0212

browser_pid = self._browser._browser_backend.pid

@@ -123,7 +123,7 @@ class TestAndroidProfilingHelper(tab_test_case.TabTestCase):

finally:

shutil.rmtree(symfs_dir)

- @test.Enabled('android')

+ @benchmark.Enabled('android')

def testGetToolchainBinaryPath(self):

with tempfile.NamedTemporaryFile() as libc:

self._device.old_interface.PullFileFromDevice('/system/lib/libc.so',