Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(350)

Issue 336233004: [Refactor] Remove hardcoded AccuracyLevel literal from DevToolsPowerHandler (Closed)

Created:
6 years, 6 months ago by vivekg_samsung
Modified:
6 years, 6 months ago
Reviewers:
vivekg, yurys
CC:
aandrey+blink_chromium.org, chromium-reviews, darin-cc_chromium.org, devtools-reviews_chromium.org, jam, paulirish+reviews_chromium.org, pfeldman, vsevik, yurys
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[Refactor] Remove hardcoded AccuracyLevel literal from DevToolsPowerHandler This was added to land chromium side changes, [1], without causing any build break. Now that blink side changes, [2], have landed, removing the hard coded literal with actual identifier. [1] https://codereview.chromium.org/332943005 [2] https://codereview.chromium.org/336713005 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=280021

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M content/browser/devtools/devtools_power_handler.cc View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
vivekg
PTAL, thanks.
6 years, 6 months ago (2014-06-26 12:33:47 UTC) #1
yurys
lgtm
6 years, 6 months ago (2014-06-26 12:55:48 UTC) #2
vivekg
The CQ bit was checked by vivekg@chromium.org
6 years, 6 months ago (2014-06-26 13:24:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vivek.vg@samsung.com/336233004/1
6 years, 6 months ago (2014-06-26 13:26:49 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg on tryserver.chromium ...
6 years, 6 months ago (2014-06-26 15:26:32 UTC) #5
commit-bot: I haz the power
6 years, 6 months ago (2014-06-26 16:37:15 UTC) #6
Message was sent while issue was closed.
Change committed as 280021

Powered by Google App Engine
This is Rietveld 408576698