Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(567)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 336713005: [Blink] [PowerProfiler] Support accuracy level attribute for power data provider. (Closed)

Created:
6 years, 6 months ago by vivekg_samsung
Modified:
6 years, 6 months ago
Reviewers:
Pan, vsevik, yurys, vivekg, tonyg, pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

[Blink] [PowerProfiler] Support accuracy level attribute for power data provider. Blink side changes in devtools protocol and front_end to utilize the accuracy level attribute from power data provider. BUG=384299 NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176966

Patch Set 1 #

Total comments: 2

Patch Set 2 : Patch for landing! #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -0 lines) Patch
M Source/devtools/front_end/sdk/PowerProfiler.js View 1 2 chunks +15 lines, -0 lines 0 comments Download
M Source/devtools/front_end/timeline/TimelinePanel.js View 1 1 chunk +1 line, -0 lines 0 comments Download
M Source/devtools/protocol.json View 1 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
vivekg
PTAL
6 years, 6 months ago (2014-06-13 11:18:03 UTC) #1
vivekg
Chromium side backend support CL here: https://codereview.chromium.org/332943005/
6 years, 6 months ago (2014-06-13 11:42:54 UTC) #2
vivekg
PowerProfiler Accuracy level DevTools Screenshot: http://i.snag.gy/VSb5a.jpg
6 years, 6 months ago (2014-06-13 11:49:47 UTC) #3
yurys
lgtm https://codereview.chromium.org/336713005/diff/1/Source/devtools/front_end/sdk/PowerProfiler.js File Source/devtools/front_end/sdk/PowerProfiler.js (right): https://codereview.chromium.org/336713005/diff/1/Source/devtools/front_end/sdk/PowerProfiler.js#newcode40 Source/devtools/front_end/sdk/PowerProfiler.js:40: return; You might want to print the error ...
6 years, 6 months ago (2014-06-17 07:38:40 UTC) #4
vivekg
On 2014/06/17 07:38:40, yurys wrote: > lgtm > > https://codereview.chromium.org/336713005/diff/1/Source/devtools/front_end/sdk/PowerProfiler.js > File Source/devtools/front_end/sdk/PowerProfiler.js (right): > ...
6 years, 6 months ago (2014-06-18 05:33:21 UTC) #5
vivekg
The CQ bit was checked by vivekg@chromium.org
6 years, 6 months ago (2014-06-26 04:14:14 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vivek.vg@samsung.com/336713005/40001
6 years, 6 months ago (2014-06-26 04:15:29 UTC) #7
vivekg
The CQ bit was unchecked by vivekg@chromium.org
6 years, 6 months ago (2014-06-26 06:46:50 UTC) #8
vivekg
The CQ bit was checked by vivekg@chromium.org
6 years, 6 months ago (2014-06-26 06:46:52 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vivek.vg@samsung.com/336713005/40001
6 years, 6 months ago (2014-06-26 06:48:00 UTC) #10
commit-bot: I haz the power
6 years, 6 months ago (2014-06-26 06:57:29 UTC) #11
Message was sent while issue was closed. 
Change committed as 176966

Powered by Google App Engine
This is Rietveld 408576698