[Chromium] [PowerProfiler] Support accuracy level attribute for power data provider.

[Chromium] [PowerProfiler] Support accuracy level attribute for power data provider.

Adding support for providing accuracy level of the power data provider.

BUG=384299
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=279956

[vivekg, 2014-06-13 11:40:46]

PTAL, Thanks!

[vivekg, 2014-06-13 11:42:15]

This CL is chrmoium side changes. For blink side changes, please refer:
https://codereview.chromium.org/336713005/

[vivekg, 2014-06-13 11:50:02]

PowerProfiler Accuracy level DevTools Screenshot: http://i.snag.gy/VSb5a.jpg

[yurys, 2014-06-17 07:45:14]

lgtm

https://codereview.chromium.org/332943005/diff/1/content/browser/devtools/dev...
File content/browser/devtools/devtools_power_handler.cc (right):

https://codereview.chromium.org/332943005/diff/1/content/browser/devtools/dev...
content/browser/devtools/devtools_power_handler.cc:24:
RegisterCommandHandler(devtools::Power::accuracyLevel::kName,
Please use getAccuracyLayer as command name (starting with a verb).

https://codereview.chromium.org/332943005/diff/1/content/browser/power_profil...
File content/browser/power_profiler/power_profiler_service.h (right):

https://codereview.chromium.org/332943005/diff/1/content/browser/power_profil...
content/browser/power_profiler/power_profiler_service.h:29: std::string
AccuracyLevel() const;
style: GetAccuracyLayer for non-trivial getters.

[vivekg, 2014-06-18 05:32:32]

On 2014/06/17 07:45:14, yurys wrote:
> lgtm
> 
>
https://codereview.chromium.org/332943005/diff/1/content/browser/devtools/dev...
> File content/browser/devtools/devtools_power_handler.cc (right):
> 
>
https://codereview.chromium.org/332943005/diff/1/content/browser/devtools/dev...
> content/browser/devtools/devtools_power_handler.cc:24:
> RegisterCommandHandler(devtools::Power::accuracyLevel::kName,
> Please use getAccuracyLayer as command name (starting with a verb).
> 
>
https://codereview.chromium.org/332943005/diff/1/content/browser/power_profil...
> File content/browser/power_profiler/power_profiler_service.h (right):
> 
>
https://codereview.chromium.org/332943005/diff/1/content/browser/power_profil...
> content/browser/power_profiler/power_profiler_service.h:29: std::string
> AccuracyLevel() const;
> style: GetAccuracyLayer for non-trivial getters.

@yurys, Thank you. I will incorporate all the review comments.

Still awaiting OWNERs review on power_profiler changes.

[vivekg, 2014-06-23 05:26:54]

> Still awaiting OWNERs review on power_profiler changes.

Friendly ping for OWNERs review.

[vivekg, 2014-06-24 03:29:42]

@tonyg: Can you please take a look at the power profiler changes?

[jam, 2014-06-24 06:57:09]

On 2014/06/23 05:26:54, vivekg_ wrote:
> > Still awaiting OWNERs review on power_profiler changes.
> 
> Friendly ping for OWNERs review.

you don't need 9 reviewers. pick two

[jam, 2014-06-24 06:57:10]

On 2014/06/23 05:26:54, vivekg_ wrote:
> > Still awaiting OWNERs review on power_profiler changes.
> 
> Friendly ping for OWNERs review.

you don't need 9 reviewers. pick two

[vivekg, 2014-06-24 06:59:34]

On 2014/06/24 at 06:57:10, jam wrote:
> On 2014/06/23 05:26:54, vivekg_ wrote:
> > > Still awaiting OWNERs review on power_profiler changes.
> > 
> > Friendly ping for OWNERs review.
> 
> you don't need 9 reviewers. pick two

Sorry, instead of CC added them in the reviewers list. Corrected now.

[vivekg, 2014-06-25 06:36:02]

@jam, @tonyg: Awaiting your comments.

[jam, 2014-06-25 21:42:27]

lgtm

[vivekg, 2014-06-26 04:11:19]

The CQ bit was checked by vivekg@chromium.org

[commit-bot: I haz the power, 2014-06-26 04:12:35]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/vivek.vg@samsung.com/332943005/20001

[commit-bot: I haz the power, 2014-06-26 07:49:49]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_chromium_gn_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_gn_rel...)

[commit-bot: I haz the power, 2014-06-26 08:10:52]

Change committed as 279956