Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Side by Side Diff: content/browser/devtools/devtools_power_handler.cc

Issue 336233004: [Refactor] Remove hardcoded AccuracyLevel literal from DevToolsPowerHandler (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/devtools/devtools_power_handler.h" 5 #include "content/browser/devtools/devtools_power_handler.h"
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/values.h" 8 #include "base/values.h"
9 #include "content/browser/devtools/devtools_protocol_constants.h" 9 #include "content/browser/devtools/devtools_protocol_constants.h"
10 #include "content/browser/power_profiler/power_profiler_service.h" 10 #include "content/browser/power_profiler/power_profiler_service.h"
11 11
12 namespace content { 12 namespace content {
13 13
14 DevToolsPowerHandler::DevToolsPowerHandler() { 14 DevToolsPowerHandler::DevToolsPowerHandler() {
15 RegisterCommandHandler(devtools::Power::start::kName, 15 RegisterCommandHandler(devtools::Power::start::kName,
16 base::Bind(&DevToolsPowerHandler::OnStart, 16 base::Bind(&DevToolsPowerHandler::OnStart,
17 base::Unretained(this))); 17 base::Unretained(this)));
18 RegisterCommandHandler(devtools::Power::end::kName, 18 RegisterCommandHandler(devtools::Power::end::kName,
19 base::Bind(&DevToolsPowerHandler::OnEnd, 19 base::Bind(&DevToolsPowerHandler::OnEnd,
20 base::Unretained(this))); 20 base::Unretained(this)));
21 RegisterCommandHandler(devtools::Power::canProfilePower::kName, 21 RegisterCommandHandler(devtools::Power::canProfilePower::kName,
22 base::Bind(&DevToolsPowerHandler::OnCanProfilePower, 22 base::Bind(&DevToolsPowerHandler::OnCanProfilePower,
23 base::Unretained(this))); 23 base::Unretained(this)));
24 // TODO(vivekg): Replace hardcoded "Power.getAccuracyLevel" with 24 RegisterCommandHandler(devtools::Power::getAccuracyLevel::kName,
25 // devtools::Power::getAccuracyLevel::kName once crrev.com/336713005 lands
26 RegisterCommandHandler("Power.getAccuracyLevel" ,
27 base::Bind(&DevToolsPowerHandler::OnGetAccuracyLevel, 25 base::Bind(&DevToolsPowerHandler::OnGetAccuracyLevel,
28 base::Unretained(this))); 26 base::Unretained(this)));
29 } 27 }
30 28
31 DevToolsPowerHandler::~DevToolsPowerHandler() { 29 DevToolsPowerHandler::~DevToolsPowerHandler() {
32 PowerProfilerService::GetInstance()->RemoveObserver(this); 30 PowerProfilerService::GetInstance()->RemoveObserver(this);
33 } 31 }
34 32
35 void DevToolsPowerHandler::OnPowerEvent(const PowerEventVector& events) { 33 void DevToolsPowerHandler::OnPowerEvent(const PowerEventVector& events) {
36 base::DictionaryValue* params = new base::DictionaryValue(); 34 base::DictionaryValue* params = new base::DictionaryValue();
(...skipping 59 matching lines...) Expand 10 before | Expand all | Expand 10 after
96 return command->SuccessResponse(result); 94 return command->SuccessResponse(result);
97 } 95 }
98 return command->InternalErrorResponse("Power profiler service unavailable"); 96 return command->InternalErrorResponse("Power profiler service unavailable");
99 } 97 }
100 98
101 void DevToolsPowerHandler::OnClientDetached() { 99 void DevToolsPowerHandler::OnClientDetached() {
102 PowerProfilerService::GetInstance()->RemoveObserver(this); 100 PowerProfilerService::GetInstance()->RemoveObserver(this);
103 } 101 }
104 102
105 } // namespace content 103 } // namespace content
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698