Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 335113002: IDL: Support argument default values (Closed)

Created:
6 years, 6 months ago by Jens Widell
Modified:
6 years, 6 months ago
CC:
blink-reviews, blink-reviews-bindings_chromium.org, arv+blink, abarth-chromium
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

IDL: Support argument default values This also changes the code generated for existing null default values, by dropping use of argumentOrNull() (which then becomes unused and is removed) and setting the argument's local variable explicitly by assigning "nullptr" to it. The use of argumentOrNull() in V8HistoryCustom.cpp was redundant; reading info[N] directly yields an undefined value, which is converted to a null string by V8StringResource<WithUndefinedOrNullCheck>. BUG=258153 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176861

Patch Set 1 #

Total comments: 3

Patch Set 2 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+110 lines, -38 lines) Patch
M Source/bindings/scripts/v8_methods.py View 1 1 chunk +1 line, -9 lines 0 comments Download
M Source/bindings/templates/methods.cpp View 1 1 chunk +8 lines, -0 lines 0 comments Download
M Source/bindings/tests/idls/TestObject.idl View 1 1 chunk +2 lines, -1 line 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceConstructor2.cpp View 1 1 chunk +5 lines, -1 line 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceNamedConstructor.cpp View 1 1 chunk +5 lines, -1 line 0 comments Download
M Source/bindings/tests/results/V8TestObject.cpp View 1 9 chunks +82 lines, -19 lines 0 comments Download
M Source/bindings/v8/V8Binding.h View 1 1 chunk +0 lines, -5 lines 0 comments Download
M Source/bindings/v8/V8StringResource.h View 1 chunk +5 lines, -0 lines 0 comments Download
M Source/bindings/v8/custom/V8HistoryCustom.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
Jens Widell
Next step, now supporting more useful syntax, and with some CG changes. There's of course ...
6 years, 6 months ago (2014-06-16 13:22:29 UTC) #1
haraken
What's your plan overall about how to treat "missing" arguments? The change looks OK but ...
6 years, 6 months ago (2014-06-16 15:09:16 UTC) #2
Nils Barth (inactive)
LGTM; a question or two. https://codereview.chromium.org/335113002/diff/1/Source/bindings/tests/idls/TestObject.idl File Source/bindings/tests/idls/TestObject.idl (right): https://codereview.chromium.org/335113002/diff/1/Source/bindings/tests/idls/TestObject.idl#newcode389 Source/bindings/tests/idls/TestObject.idl:389: void voidMethodDefaultNullableByteStringArg(optional ByteString? defaultStringArg ...
6 years, 6 months ago (2014-06-17 03:40:32 UTC) #3
Nils Barth (inactive)
On 2014/06/16 13:22:29, Jens Lindström wrote: > There's of course also the small matter of ...
6 years, 6 months ago (2014-06-17 03:41:39 UTC) #4
Nils Barth (inactive)
On 2014/06/16 15:09:16, haraken wrote: > What's your plan overall about how to treat "missing" ...
6 years, 6 months ago (2014-06-17 03:53:47 UTC) #5
Jens Widell
On 2014/06/16 15:09:16, haraken wrote: > What's your plan overall about how to treat "missing" ...
6 years, 6 months ago (2014-06-24 11:04:17 UTC) #6
haraken
On 2014/06/24 11:04:17, Jens Lindström wrote: > On 2014/06/16 15:09:16, haraken wrote: > > What's ...
6 years, 6 months ago (2014-06-24 15:59:45 UTC) #7
Jens Widell
The CQ bit was checked by jl@opera.com
6 years, 6 months ago (2014-06-24 16:11:28 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jl@opera.com/335113002/20001
6 years, 6 months ago (2014-06-24 16:11:56 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_gpu_retina_triggered_tests on tryserver.chromium.gpu ...
6 years, 6 months ago (2014-06-24 17:33:32 UTC) #10
commit-bot: I haz the power
6 years, 6 months ago (2014-06-24 18:04:10 UTC) #11
Message was sent while issue was closed.
Change committed as 176861

Powered by Google App Engine
This is Rietveld 408576698