Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(355)

Unified Diff: Source/bindings/templates/methods.cpp

Issue 335113002: IDL: Support argument default values (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: rebased Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/scripts/v8_methods.py ('k') | Source/bindings/tests/idls/TestObject.idl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/templates/methods.cpp
diff --git a/Source/bindings/templates/methods.cpp b/Source/bindings/templates/methods.cpp
index 4a44e7228dc0ce23b2376546459023e7542a645f..a90f7813893ba099bb4fa2c65f659d81acccb658 100644
--- a/Source/bindings/templates/methods.cpp
+++ b/Source/bindings/templates/methods.cpp
@@ -84,7 +84,15 @@ if (listener && !impl->toNode())
V8RethrowTryCatchScope rethrow(block);
{% endif %}
{% for argument in method.arguments %}
+ {% if argument.default_value %}
+ if (info.Length() > {{argument.index}}) {
+ {{generate_argument(method, argument, world_suffix) | indent(8)}}
+ } else {
+ {{argument.name}} = {{argument.default_value}};
+ }
+ {% else %}
{{generate_argument(method, argument, world_suffix) | indent}}
+ {% endif %}
{% endfor %}
}
{% endmacro %}
« no previous file with comments | « Source/bindings/scripts/v8_methods.py ('k') | Source/bindings/tests/idls/TestObject.idl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698