Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(403)

Unified Diff: Source/bindings/v8/custom/V8HistoryCustom.cpp

Issue 335113002: IDL: Support argument default values (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: rebased Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/v8/V8StringResource.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/v8/custom/V8HistoryCustom.cpp
diff --git a/Source/bindings/v8/custom/V8HistoryCustom.cpp b/Source/bindings/v8/custom/V8HistoryCustom.cpp
index ec963bf1204efba9738c01bcebfe728737824c96..0b8de4adc976fba88fd30de8334fcaff946575f2 100644
--- a/Source/bindings/v8/custom/V8HistoryCustom.cpp
+++ b/Source/bindings/v8/custom/V8HistoryCustom.cpp
@@ -67,7 +67,7 @@ void V8History::pushStateMethodCustom(const v8::FunctionCallbackInfo<v8::Value>&
return;
TOSTRING_VOID(V8StringResource<WithUndefinedOrNullCheck>, title, info[1]);
- TOSTRING_VOID(V8StringResource<WithUndefinedOrNullCheck>, url, argumentOrNull(info, 2));
+ TOSTRING_VOID(V8StringResource<WithUndefinedOrNullCheck>, url, info[2]);
History* history = V8History::toNative(info.Holder());
history->stateObjectAdded(historyState.release(), title, url, FrameLoadTypeStandard, exceptionState);
@@ -83,7 +83,7 @@ void V8History::replaceStateMethodCustom(const v8::FunctionCallbackInfo<v8::Valu
return;
TOSTRING_VOID(V8StringResource<WithUndefinedOrNullCheck>, title, info[1]);
- TOSTRING_VOID(V8StringResource<WithUndefinedOrNullCheck>, url, argumentOrNull(info, 2));
+ TOSTRING_VOID(V8StringResource<WithUndefinedOrNullCheck>, url, info[2]);
History* history = V8History::toNative(info.Holder());
history->stateObjectAdded(historyState.release(), title, url, FrameLoadTypeRedirectWithLockedBackForwardList, exceptionState);
« no previous file with comments | « Source/bindings/v8/V8StringResource.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698