Source/bindings/v8/V8Binding.h - Issue 335113002: IDL: Support argument default values

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/v8/V8Binding.h

Issue 335113002: IDL: Support argument default values (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: rebased Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/v8/V8Binding.h

diff --git a/Source/bindings/v8/V8Binding.h b/Source/bindings/v8/V8Binding.h

index fabf358f47dffc22efec18c3542c31523343cb76..f73f30c4ebaf0753eff2008062ae2830c1bfc2f0 100644

--- a/Source/bindings/v8/V8Binding.h

+++ b/Source/bindings/v8/V8Binding.h

@@ -86,11 +86,6 @@ bool invokeCallback(ScriptState*, v8::Local<v8::Function> callback, v8::Handle<v

v8::ArrayBuffer::Allocator* v8ArrayBufferAllocator();

-inline v8::Handle<v8::Value> argumentOrNull(const v8::FunctionCallbackInfo<v8::Value>& info, int index)

- return index >= info.Length() ? v8::Local<v8::Value>() : info[index];

template<typename CallbackInfo, typename V>

inline void v8SetReturnValue(const CallbackInfo& info, V v)

{