Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issue 33353003: Have Frame::tree() return a reference (Closed)

Created:
7 years, 2 months ago by Inactive
Modified:
7 years, 2 months ago
Reviewers:
tkent, adamk, eseidel
CC:
blink-reviews, eae+blinkwatch, apavlov+blink_chromium.org, adamk+blink_chromium.org, pdr, aandrey+blink_chromium.org, Nils Barth (inactive), blink-layers+watch_chromium.org, caseq+blink_chromium.org, Nate Chapin, yurys+blink_chromium.org, abarth-chromium, marja+watch_chromium.org, dglazkov+blink, gavinp+loader_chromium.org, jchaffraix+rendering, devtools-reviews_chromium.org, Inactive, kenneth.christiansen, loislo+blink_chromium.org, zoltan1, lushnikov+blink_chromium.org, eustas+blink_chromium.org, paulirish+reviews_chromium.org, haraken, kojih, jsbell+bindings_chromium.org, alph+blink_chromium.org, leviw+renderwatch, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, f(malita), groby+blinkspell_chromium.org, Stephen Chennney
Visibility:
Public.

Description

Have Frame::tree() return a reference Have Frame::tree() return a reference as it can never return null. This makes the calling code look safer. BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=160216

Patch Set 1 #

Patch Set 2 : Rebase on master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+245 lines, -247 lines) Patch
M Source/bindings/v8/custom/V8WindowCustom.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/dom/Document.cpp View 1 11 chunks +15 lines, -15 lines 0 comments Download
M Source/core/dom/DocumentInit.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/FullscreenElementStack.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/dom/TouchController.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/TreeScope.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/editing/FrameSelection.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/SpellChecker.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/fetch/ResourceFetcher.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/frame/DOMWindow.cpp View 10 chunks +11 lines, -11 lines 0 comments Download
M Source/core/frame/Frame.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/frame/Frame.cpp View 10 chunks +10 lines, -10 lines 0 comments Download
M Source/core/frame/FrameView.cpp View 1 8 chunks +8 lines, -8 lines 0 comments Download
M Source/core/frame/Location.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLDocument.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/InspectorApplicationCacheAgent.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/InspectorCanvasAgent.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/InspectorDOMAgent.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/InspectorFileSystemAgent.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/InspectorPageAgent.cpp View 1 6 chunks +7 lines, -7 lines 0 comments Download
M Source/core/inspector/PageRuntimeAgent.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/loader/DocumentLoader.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/loader/FrameLoader.cpp View 25 chunks +29 lines, -29 lines 0 comments Download
M Source/core/loader/HistoryController.cpp View 11 chunks +15 lines, -15 lines 0 comments Download
M Source/core/loader/IconController.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/loader/NavigationScheduler.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/loader/ProgressTracker.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/loader/TextResourceDecoderBuilder.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/page/Chrome.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/page/CreateWindow.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/page/EventHandler.cpp View 1 5 chunks +6 lines, -6 lines 0 comments Download
M Source/core/page/FocusController.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/page/FrameTree.cpp View 19 chunks +43 lines, -43 lines 0 comments Download
M Source/core/page/Page.cpp View 1 12 chunks +14 lines, -14 lines 0 comments Download
M Source/core/page/PageGroup.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/page/PageGroupLoadDeferrer.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/page/PageSerializer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/page/Settings.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/page/SpatialNavigation.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/page/scrolling/ScrollingCoordinator.cpp View 1 3 chunks +5 lines, -5 lines 0 comments Download
M Source/core/rendering/HitTestResult.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderLayerCompositor.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/rendering/TextAutosizer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGSVGElement.cpp View 2 chunks +4 lines, -6 lines 0 comments Download
M Source/core/testing/Internals.cpp View 1 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/xml/parser/XMLDocumentParser.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/web/EditorClientImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/StorageAreaProxy.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/web/WebFrameImpl.cpp View 8 chunks +20 lines, -20 lines 0 comments Download
M Source/web/WebViewImpl.cpp View 1 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Inactive
7 years, 2 months ago (2013-10-21 18:55:25 UTC) #1
eseidel
lgtm
7 years, 2 months ago (2013-10-21 19:05:25 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/33353003/1
7 years, 2 months ago (2013-10-21 19:10:50 UTC) #3
commit-bot: I haz the power
Retried try job too often on win_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_blink_rel&number=12849
7 years, 2 months ago (2013-10-22 00:28:51 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/33353003/1
7 years, 2 months ago (2013-10-22 13:19:33 UTC) #5
commit-bot: I haz the power
Failed to apply patch for Source/core/frame/Frame.h: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
7 years, 2 months ago (2013-10-22 13:19:46 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/33353003/170001
7 years, 2 months ago (2013-10-22 13:30:04 UTC) #7
commit-bot: I haz the power
7 years, 2 months ago (2013-10-22 14:55:38 UTC) #8
Message was sent while issue was closed.
Change committed as 160216

Powered by Google App Engine
This is Rietveld 408576698