Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(436)

Side by Side Diff: Source/core/page/SpatialNavigation.cpp

Issue 33353003: Have Frame::tree() return a reference (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Rebase on master Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/page/Settings.cpp ('k') | Source/core/page/scrolling/ScrollingCoordinator.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009 Nokia Corporation and/or its subsidiary(-ies) 2 * Copyright (C) 2009 Nokia Corporation and/or its subsidiary(-ies)
3 * Copyright (C) 2009 Antonio Gomes <tonikitoo@webkit.org> 3 * Copyright (C) 2009 Antonio Gomes <tonikitoo@webkit.org>
4 * 4 *
5 * All rights reserved. 5 * All rights reserved.
6 * 6 *
7 * Redistribution and use in source and binary forms, with or without 7 * Redistribution and use in source and binary forms, with or without
8 * modification, are permitted provided that the following conditions 8 * modification, are permitted provided that the following conditions
9 * are met: 9 * are met:
10 * 1. Redistributions of source code must retain the above copyright 10 * 1. Redistributions of source code must retain the above copyright
(...skipping 484 matching lines...) Expand 10 before | Expand all | Expand 10 after
495 return rect.height() + offset.height() < size.height(); 495 return rect.height() + offset.height() < size.height();
496 default: 496 default:
497 ASSERT_NOT_REACHED(); 497 ASSERT_NOT_REACHED();
498 return false; 498 return false;
499 } 499 }
500 } 500 }
501 501
502 static LayoutRect rectToAbsoluteCoordinates(Frame* initialFrame, const LayoutRec t& initialRect) 502 static LayoutRect rectToAbsoluteCoordinates(Frame* initialFrame, const LayoutRec t& initialRect)
503 { 503 {
504 LayoutRect rect = initialRect; 504 LayoutRect rect = initialRect;
505 for (Frame* frame = initialFrame; frame; frame = frame->tree()->parent()) { 505 for (Frame* frame = initialFrame; frame; frame = frame->tree().parent()) {
506 if (Element* element = frame->ownerElement()) { 506 if (Element* element = frame->ownerElement()) {
507 do { 507 do {
508 rect.move(element->offsetLeft(), element->offsetTop()); 508 rect.move(element->offsetLeft(), element->offsetTop());
509 } while ((element = element->offsetParent())); 509 } while ((element = element->offsetParent()));
510 rect.move((-frame->view()->scrollOffset())); 510 rect.move((-frame->view()->scrollOffset()));
511 } 511 }
512 } 512 }
513 return rect; 513 return rect;
514 } 514 }
515 515
(...skipping 214 matching lines...) Expand 10 before | Expand all | Expand 10 after
730 LayoutRect rect = virtualRectForDirection(direction, rectToAbsoluteCoordinat es(area->document().frame(), area->computeRect(area->imageElement()->renderer()) ), 1); 730 LayoutRect rect = virtualRectForDirection(direction, rectToAbsoluteCoordinat es(area->document().frame(), area->computeRect(area->imageElement()->renderer()) ), 1);
731 return rect; 731 return rect;
732 } 732 }
733 733
734 HTMLFrameOwnerElement* frameOwnerElement(FocusCandidate& candidate) 734 HTMLFrameOwnerElement* frameOwnerElement(FocusCandidate& candidate)
735 { 735 {
736 return candidate.isFrameOwnerElement() ? toHTMLFrameOwnerElement(candidate.v isibleNode) : 0; 736 return candidate.isFrameOwnerElement() ? toHTMLFrameOwnerElement(candidate.v isibleNode) : 0;
737 }; 737 };
738 738
739 } // namespace WebCore 739 } // namespace WebCore
OLDNEW
« no previous file with comments | « Source/core/page/Settings.cpp ('k') | Source/core/page/scrolling/ScrollingCoordinator.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698