Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(466)

Unified Diff: Source/web/WebViewImpl.cpp

Issue 33353003: Have Frame::tree() return a reference (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Rebase on master Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/web/WebFrameImpl.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/web/WebViewImpl.cpp
diff --git a/Source/web/WebViewImpl.cpp b/Source/web/WebViewImpl.cpp
index 90413e89eb7ef68c079c3261fb24e49e695eb6f9..4a5aa0054d3087dcd596e8ca0c7cf8d41268b38e 100644
--- a/Source/web/WebViewImpl.cpp
+++ b/Source/web/WebViewImpl.cpp
@@ -1543,7 +1543,7 @@ bool WebViewImpl::propagateScroll(ScrollDirection scrollDirection,
Frame* currentFrame = frame;
while (!scrollHandled && currentFrame) {
scrollHandled = currentFrame->view()->scroll(scrollDirection, scrollGranularity);
- currentFrame = currentFrame->tree()->parent();
+ currentFrame = currentFrame->tree().parent();
}
return scrollHandled;
}
@@ -2578,7 +2578,7 @@ WebFrame* WebViewImpl::findFrameByName(
if (!relativeToFrame)
relativeToFrame = mainFrame();
Frame* frame = toWebFrameImpl(relativeToFrame)->frame();
- frame = frame->tree()->find(name);
+ frame = frame->tree().find(name);
return WebFrameImpl::fromFrame(frame);
}
@@ -3295,7 +3295,7 @@ void WebViewImpl::dragTargetDrop(const WebPoint& clientPoint,
void WebViewImpl::spellingMarkers(WebVector<uint32_t>* markers)
{
Vector<uint32_t> result;
- for (Frame* frame = m_page->mainFrame(); frame; frame = frame->tree()->traverseNext()) {
+ for (Frame* frame = m_page->mainFrame(); frame; frame = frame->tree().traverseNext()) {
const Vector<DocumentMarker*>& documentMarkers = frame->document()->markers()->markers();
for (size_t i = 0; i < documentMarkers.size(); ++i)
result.append(documentMarkers[i]->hash());
@@ -3534,7 +3534,7 @@ void WebViewImpl::setIsTransparent(bool isTransparent)
Frame* frame = m_page->mainFrame();
while (frame) {
frame->view()->setTransparent(isTransparent);
- frame = frame->tree()->traverseNext();
+ frame = frame->tree().traverseNext();
}
// Future frames check this to know whether to be transparent.
« no previous file with comments | « Source/web/WebFrameImpl.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698