Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issue 333243004: Rename GN source_prereqs to inputs, enhance "desc" (Closed)

Created:
6 years, 6 months ago by brettw
Modified:
6 years, 6 months ago
Reviewers:
jamesr
CC:
chromium-reviews, tfarina
Project:
chromium
Visibility:
Public.

Description

Rename GN source_prereqs to inputs, enhance "desc" We picked the name "source_prereqs" to try to emphasize that these are source (compile-time) dependencies rather than data or link-time dependencies. However, now that all actions are implicit hard deps, the use-case of using this for binary targets is almost nonexistant (I want to eventually put back actions-as-soft-deps but this requires some additional checking to make sure people don't mess up, at which time this may becomre more relevant.) source_prereqs is hard to type and difficult to understand. Inputs is much more clear, especially since the typical case is an action. This will fall back to reading "source_prereqs" for back-compat until we change all users. Significantly enhance the "gn desc" command. A bunch of action-related fields were missing. BUG=374271 R=jamesr@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277850

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+298 lines, -110 lines) Patch
M tools/gn/action_target_generator.cc View 1 chunk +1 line, -1 line 0 comments Download
M tools/gn/binary_target_generator.cc View 1 chunk +1 line, -1 line 0 comments Download
M tools/gn/command_desc.cc View 1 9 chunks +196 lines, -22 lines 0 comments Download
M tools/gn/functions_target.cc View 8 chunks +23 lines, -15 lines 0 comments Download
M tools/gn/ninja_action_target_writer_unittest.cc View 4 chunks +4 lines, -5 lines 0 comments Download
M tools/gn/ninja_target_writer.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/gn/ninja_target_writer_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/gn/target.h View 2 chunks +3 lines, -3 lines 0 comments Download
M tools/gn/target_generator.h View 1 chunk +1 line, -1 line 0 comments Download
M tools/gn/target_generator.cc View 1 chunk +14 lines, -7 lines 0 comments Download
M tools/gn/variables.h View 2 chunks +4 lines, -4 lines 0 comments Download
M tools/gn/variables.cc View 5 chunks +47 lines, -47 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
brettw
6 years, 6 months ago (2014-06-16 19:28:49 UTC) #1
jamesr
lgtm
6 years, 6 months ago (2014-06-16 20:18:04 UTC) #2
brettw
6 years, 6 months ago (2014-06-17 20:26:59 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r277850 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698